Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error about invalid offset with FS backend #2286

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

yquansah
Copy link
Contributor

Should fix: #2284

If any entity was being Listed and it had zero elements, it would return the:

invalid offset: 0

error. This should fix that issue.

@yquansah yquansah requested a review from a team as a code owner October 26, 2023 01:22
@yquansah yquansah temporarily deployed to uffizzi October 26, 2023 01:29 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Uffizzi Preview deployment-39488 was deleted.

@markphelps markphelps changed the title chore: fix error about invalid offset with FS backend fix: error about invalid offset with FS backend Oct 26, 2023
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! Thanks @yquansah !

@yquansah yquansah merged commit 1326c47 into main Oct 26, 2023
18 of 23 checks passed
@yquansah yquansah deleted the fix-index-zero branch October 26, 2023 02:07
@yquansah yquansah temporarily deployed to uffizzi October 26, 2023 02:07 — with GitHub Actions Inactive
@yquansah yquansah temporarily deployed to uffizzi October 26, 2023 02:13 — with GitHub Actions Inactive
markphelps added a commit that referenced this pull request Oct 26, 2023
markphelps added a commit that referenced this pull request Oct 26, 2023
* release/1.29:
  chore: spelling
  chore: update changelog; mod tidy
  chore: fix error about invalid offset with FS backend (#2286)
  chore: tests were broken because of this fixed it up (#2290)
  chore(deps): bump google.golang.org/grpc in /_tools (#2278)
  chore(deps): bump google.golang.org/grpc in /rpc/flipt (#2281)
  chore(deps): bump google.golang.org/grpc in /examples/basic (#2282)
  chore(deps): bump google.golang.org/grpc in /sdk/go (#2279)
  chore(deps): bump google.golang.org/grpc in /examples/openfeature (#2283)
  chore(deps): bump google.golang.org/grpc from 1.58.2 to 1.58.3 in /build (#2280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Flags not from Default namespace does not appearing in git storage mode.
2 participants