chore: fix error about invalid offset with FS backend (#2286)

Co-authored-by: Mark Phelps <[email protected]>
flipt-io · Oct 26, 2023 · 302fe8c · 302fe8c
1 parent 8623a43
commit 302fe8c
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/internal/storage/fs/fixtures/empty_features/features.yml b/internal/storage/fs/fixtures/empty_features/features.yml
diff --git a/internal/storage/fs/snapshot.go b/internal/storage/fs/snapshot.go
@@ -883,6 +883,10 @@ func find[T any](match func(T) bool, ts ...T) (t T, _ bool) {
 }
 
 func paginate[T any](params storage.QueryParams, less func(i, j int) bool, items ...T) (storage.ResultSet[T], error) {
+	if len(items) == 0 {
+		return storage.ResultSet[T]{}, nil
+	}
+
 	set := storage.ResultSet[T]{
 		Results: items,
 	}

diff --git a/internal/storage/fs/snapshot_test.go b/internal/storage/fs/snapshot_test.go
@@ -1670,6 +1670,24 @@ func TestFS_Invalid_BooleanFlag_Segment(t *testing.T) {
 	require.EqualError(t, err, "flag fruit/apple rule 1 references unknown segment \"unknown\"")
 }
 
+func TestFS_Empty_Features_File(t *testing.T) {
+	fs, _ := fs.Sub(testdata, "fixtures/empty_features")
+	ss, err := SnapshotFromFS(zaptest.NewLogger(t), fs)
+	require.NoError(t, err)
+
+	_, err = ss.ListFlags(context.TODO(), flipt.DefaultNamespace)
+	require.NoError(t, err)
+
+	_, err = ss.ListSegments(context.TODO(), flipt.DefaultNamespace)
+	require.NoError(t, err)
+
+	_, err = ss.ListRollouts(context.TODO(), flipt.DefaultNamespace, "no-flag")
+	require.NoError(t, err)
+
+	_, err = ss.ListRules(context.TODO(), flipt.DefaultNamespace, "no-flag")
+	require.NoError(t, err)
+}
+
 func TestFS_YAML_Stream(t *testing.T) {
 	fs, _ := fs.Sub(testdata, "fixtures/yaml_stream")
 	ss, err := SnapshotFromFS(zaptest.NewLogger(t), fs)