-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: context cancelled/deadline exceeded errors coming back internal #1803
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
==========================================
- Coverage 70.41% 70.28% -0.13%
==========================================
Files 58 58
Lines 5550 5563 +13
==========================================
+ Hits 3908 3910 +2
- Misses 1419 1427 +8
- Partials 223 226 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We could always setup whipt
against it with a low timeout.
* main: (66 commits) chore: Labs link (#1813) chore: add feedback link to app footer (#1812) chore(deps-dev): bump eslint-plugin-playwright in /ui (#1818) chore(deps): bump react-router-dom from 6.14.0 to 6.14.1 in /ui (#1819) chore(deps-dev): bump @typescript-eslint/parser in /ui (#1817) chore(deps-dev): bump ts-jest from 29.1.0 to 29.1.1 in /ui (#1816) chore(deps): bump google.golang.org/protobuf from 1.30.0 to 1.31.0 (#1815) chore(deps): bump google.golang.org/protobuf in /_tools (#1814) fix: Fix validate command (#1811) chore: fix deprecated archive replacement (#1807) docs: add charlesoconor as a contributor for doc (#1810) Update import in the README (#1809) fix: context cancelled/deadline exceeded errors coming back internal (#1803) chore: add to codecov ignore (#1804) chore(deps): bump react-router-dom from 6.13.0 to 6.14.0 in /ui (#1794) chore: add docker to devcontainer so can run tests (#1799) chore(deps-dev): bump @typescript-eslint/parser in /ui (#1797) chore(deps): bump @tanstack/react-table from 8.9.2 to 8.9.3 in /ui (#1795) chore(deps): bump swr from 2.1.5 to 2.2.0 in /ui (#1793) chore: address fixes from PR feedback ...
Fixes: #1801
context.Canceled
andcontext.DeadlineExceeded
errors and returns proper GRPC code instead ofInternal
movesErrorUnaryInterceptor
up the chain so its before any of our other custom middlewareWithUnaryServerChain
fromgrpc_middleware
package togrpc.ChainUnaryInterceptor
. The former just called the latter anywaysTODO
ErrorInterceptor
is always the outer most