Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docker to devcontainer so can run tests #1799

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

markphelps
Copy link
Collaborator

  • add Docker to devcontainer so we can run all our unit tests in a Codespace (including those that rely on testcontainers0
  • adds gotest for colored test output (💅🏻)
  • try to get the first run / welcome msg to work.. not sure if it will though

@markphelps markphelps requested a review from a team as a code owner June 27, 2023 20:17
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1799 (17d2318) into main (f5a1e4d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1799   +/-   ##
=======================================
  Coverage   70.41%   70.41%           
=======================================
  Files          58       58           
  Lines        5550     5550           
=======================================
  Hits         3908     3908           
  Misses       1419     1419           
  Partials      223      223           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@markphelps markphelps merged commit 99487b8 into main Jun 28, 2023
@markphelps markphelps deleted the devcontainer-fixes branch June 28, 2023 11:34
markphelps added a commit that referenced this pull request Jul 3, 2023
* main: (66 commits)
  chore: Labs link (#1813)
  chore: add feedback link to app footer (#1812)
  chore(deps-dev): bump eslint-plugin-playwright in /ui (#1818)
  chore(deps): bump react-router-dom from 6.14.0 to 6.14.1 in /ui (#1819)
  chore(deps-dev): bump @typescript-eslint/parser in /ui (#1817)
  chore(deps-dev): bump ts-jest from 29.1.0 to 29.1.1 in /ui (#1816)
  chore(deps): bump google.golang.org/protobuf from 1.30.0 to 1.31.0 (#1815)
  chore(deps): bump google.golang.org/protobuf in /_tools (#1814)
  fix: Fix validate command (#1811)
  chore: fix deprecated archive replacement (#1807)
  docs: add charlesoconor as a contributor for doc (#1810)
  Update import in the README (#1809)
  fix: context cancelled/deadline exceeded errors coming back internal (#1803)
  chore: add  to codecov ignore (#1804)
  chore(deps): bump react-router-dom from 6.13.0 to 6.14.0 in /ui (#1794)
  chore: add docker to devcontainer so can run tests (#1799)
  chore(deps-dev): bump @typescript-eslint/parser in /ui (#1797)
  chore(deps): bump @tanstack/react-table from 8.9.2 to 8.9.3 in /ui (#1795)
  chore(deps): bump swr from 2.1.5 to 2.2.0 in /ui (#1793)
  chore: address fixes from PR feedback
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants