Add tag prefix v in release link

[dstotijn]

No description provided.

[GeorgeMac]

Hey @dstotijn Thanks for the proposal here!

We've had a long tail of these v issues since we did some work in our gorelease script to support the fact we have a kind of Go monorepo here. The way we fixed it has lead to gorelease stripping the v off the version tag when we release. This is another one of those spots.

The more complete fix here would be to update the following line shown here:

flipt/.goreleaser.yml

Line 9 in 182662a

- -s -w -X main.version={{ .Version }} -X main.commit={{ .Commit }} -X main.date={{ .Date }} -X main.analyticsKey={{ .Env.ANALYTICS_KEY }}

-      - -s -w -X main.version={{ .Version }} -X main.commit={{ .Commit }} -X main.date={{ .Date }} -X main.analyticsKey={{ .Env.ANALYTICS_KEY }}
+      - -s -w -X main.version=v{{ .Version }} -X main.commit={{ .Commit }} -X main.date={{ .Date }} -X main.analyticsKey={{ .Env.ANALYTICS_KEY }}

Would you mind changing it there instead in this PR?
Then I will hapily approve and merge. It should then be fixed in the next patch release.
We're putting a patch release out this week as we have some other fixes in the pipeline.

[markphelps]

Thanks @dstotijn !! Our release process changed somewhat recently which messed w the tag. Much appreciated!

Edit: what @GeorgeMac said

[codecov]

Codecov Report

Merging #1757 (7ac3084) into main (182662a) will decrease coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 7ac3084 differs from pull request most recent head 86195ce. Consider uploading reports for the commit 86195ce to get more accurate results

@@            Coverage Diff             @@
##             main    #1757      +/-   ##
==========================================
- Coverage   78.04%   77.92%   -0.13%     
==========================================
  Files          55       55              
  Lines        4905     4905              
==========================================
- Hits         3828     3822       -6     
- Misses        853      857       +4     
- Partials      224      226       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dstotijn]

Hey gang,
Made the recommended change. Maybe you can double check if githubReleaseChecker.check will still work, but because it uses semver.ParseTolerant, it should be fine with the leading "v".

[markphelps]

Thanks again @dstotijn

[markphelps]

@all-contributors please add @dstotijn for code

[allcontributors]

@markphelps

I've put up a pull request to add @dstotijn! 🎉

[GeorgeMac]

Nice one @dstotijn ! 🙇