Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): track storage type and experimental features #1745

Merged
merged 8 commits into from
Jun 13, 2023

Conversation

GeorgeMac
Copy link
Member

Fixes FLI-404

This adds two new properties to the existing telemetry data.
These include:

  • The storage type if defined (currently one of ["", database, local or git]).
  • The entire experimental feature flag section (whether or not an experimental feature was enabled).

@GeorgeMac GeorgeMac requested a review from a team as a code owner June 13, 2023 12:02
@GeorgeMac GeorgeMac changed the title feat(telemetry): track storage type feat(telemetry): track storage type and experimental features Jun 13, 2023
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1745 (6a9f0d7) into main (5d92d68) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 6a9f0d7 differs from pull request most recent head 5ca1f40. Consider uploading reports for the commit 5ca1f40 to get more accurate results

@@            Coverage Diff             @@
##             main    #1745      +/-   ##
==========================================
- Coverage   78.03%   78.02%   -0.02%     
==========================================
  Files          55       55              
  Lines        4903     4905       +2     
==========================================
+ Hits         3826     3827       +1     
- Misses        853      854       +1     
  Partials      224      224              
Impacted Files Coverage Δ
internal/telemetry/telemetry.go 62.35% <100.00%> (+0.44%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one request, otherwise lgtm!

internal/telemetry/telemetry_test.go Outdated Show resolved Hide resolved
@GeorgeMac GeorgeMac requested a review from markphelps June 13, 2023 15:33
@GeorgeMac GeorgeMac added the automerge Used by Kodiak bot to automerge PRs label Jun 13, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jun 13, 2023
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@kodiakhq kodiakhq bot merged commit 9c2826b into main Jun 13, 2023
@kodiakhq kodiakhq bot deleted the gm/fs-telemetry branch June 13, 2023 17:04
markphelps added a commit that referenced this pull request Jun 15, 2023
* main: (21 commits)
  chore: update schemas to include prepared statements
  chore: fix tests for urls
  chore: pgbouncer config fix
  chore(deps): bump formik from 2.4.1 to 2.4.2 in /ui (#1756)
  docs: add dstotijn as a contributor for code (#1759)
  Add tag prefix `v` in release link (#1757)
  fix(storage/sql): set binary_parameters=yes for lib/pq when prepared statements disabled
  chore(deps): bump react-router-dom from 6.12.1 to 6.13.0 in /ui (#1755)
  feat: configure use of prepared statements
  fix: input bg / text in darkmode (#1752)
  chore: rm markphelps from auto assignee on issue templates (#1751)
  docs: add yuvalg99 as a contributor for design (#1748)
  Fixed the dark mode in select component. (#1747)
  feat(telemetry): track storage type and experimental features (#1745)
  chore(deps-dev): bump @types/node from 18.16.17 to 18.16.18 in /ui (#1744)
  chore(deps-dev): bump @typescript-eslint/eslint-plugin in /ui (#1741)
  chore: fix Dagger UI build as node-18 bumped to a different base image of debian (bookworm) (#1746)
  chore(deps-dev): bump @types/react-dom from 18.2.4 to 18.2.5 in /ui (#1740)
  fix: count rules was not taking flagKey into account (#1738)
  chore(deps-dev): bump @types/node from 18.16.16 to 18.16.17 in /ui (#1736)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants