feat: support config versioning #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to config-version * 'config-version' of https://github.com/flipt-io/flipt:
markphelps
changed the title
markphelps
commented
Dec 16, 2022
| @@ -173,6 +181,15 @@ func bindEnvVars(v *viper.Viper, prefix string, field reflect.StructField) { | |||
| v.MustBindEnv(key) | |||
| } | |||
|
|
|||
| func (c *Config) validate() (err error) { | |||
| if c.Version != "" { | |||
| if strings.TrimSpace(c.Version) != "1.0" { | |||
There was a problem hiding this comment.
id like to make this smarter in the future, potentially using some form of semver parsing (to two places x.x), wyt?
There was a problem hiding this comment.
Yeah, that could be good. Like a way to ratchet up minor version changes in the config.
GeorgeMac
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds optional version number support to our config