Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor deprecations checking to own method #1226

Merged
merged 4 commits into from
Dec 15, 2022
Merged

chore: refactor deprecations checking to own method #1226

merged 4 commits into from
Dec 15, 2022

Conversation

markphelps
Copy link
Collaborator

Small refactor to move deprecations checking into its own step in the config parsing

  • creates deprecation type to hold field name and any additional message`
  • creates deprecator interface to check if any fields are deprecated and return a slice of deprecations that will be appended to warnings on the config
  • removes the need to return []string in the setDefaults method/interface

@markphelps markphelps requested a review from a team as a code owner December 15, 2022 15:23
GeorgeMac
GeorgeMac approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat!

@markphelps markphelps merged commit f546cf8 into main Dec 15, 2022
@markphelps markphelps deleted the deprecations-refactor branch December 15, 2022 15:45
markphelps added a commit that referenced this pull request Dec 16, 2022
@markphelps
Merge branch 'main' into config-version
7a6cd0a 
* main:
  feat: deprecate ui enabled (#1227)
  chore: move migrator back to main so we dont need it in grpc server (#1224)
  chore: refactor deprecations checking to own method (#1226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @GeorgeMac