chore: rm it image #1152
Merged
chore: rm it image #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
markphelps
commented
Nov 22, 2022
•
markphelps
commented
- chore: Remove need for building/publishing IT image and running ITs in Docker
- chore: rm Redis IT test for now because it (Flipt) keeps failing with inability to connect
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
+ Coverage 79.91% 80.08% +0.16%
==========================================
Files 35 36 +1
Lines 2435 2465 +30
==========================================
+ Hits 1946 1974 +28
- Misses 393 394 +1
- Partials 96 97 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…rm-it-image * 'rm-it-image' of https://github.com/flipt-io/flipt: Add Asphalt logo to users (#1153)
GeorgeMac
pushed a commit
that referenced
this pull request
Nov 28, 2022
* chore: try to remove IT image * chore: rm node install where not needed * chore: try with sudo * chore: fix needs for API test * rm IT action * chore: try to fix build * chore: try to fix run commands * chore: try to fix run * Set e * chore: timeouts and sudo * chore: try to use uuidgen instead * Try 0.0.0.0 * Rm e * Try to fix redis test * always run log upload step * try to expose redis port on host * rm redis test
markphelps
added a commit
that referenced
this pull request
Nov 28, 2022
…1175) (#1176) * fix(auth): mount core auth service via grpc gateway (#1175) * fix(auth): mount core auth service via grpc gateway * fix(test): fallback to empty string when variable unbound * fix(test): cat -> echo * fix(test): reorder args to shakedown * fix(test): export FLIPT_TOKEN variable properly * fix(test): use jq -r to get unquoted string * fix(auth): register authentication service handler on gateway * fix(middleware): error interceptor forward grpc status errors * fix(test): adjust /auth/v1/self assertion on authentication requirement * fix(test): adjust if condition * chore: rm it image (#1152) * chore: try to remove IT image * chore: rm node install where not needed * chore: try with sudo * chore: fix needs for API test * rm IT action * chore: try to fix build * chore: try to fix run commands * chore: try to fix run * Set e * chore: timeouts and sudo * chore: try to use uuidgen instead * Try 0.0.0.0 * Rm e * Try to fix redis test * always run log upload step * try to expose redis port on host * rm redis test * chore: update CHANGELOG Co-authored-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.