chore: rm it image (#1152)

* chore: try to remove IT image * chore: rm node install where not needed * chore: try with sudo * chore: fix needs for API test * rm IT action * chore: try to fix build * chore: try to fix run commands * chore: try to fix run * Set e * chore: timeouts and sudo * chore: try to use uuidgen instead * Try 0.0.0.0 * Rm e * Try to fix redis test * always run log upload step * try to expose redis port on host * rm redis test
flipt-io · Nov 22, 2022 · 80b4478 · 80b4478
1 parent 8a65d56
commit 80b4478
Show file tree

Hide file tree

Showing 6 changed files with 61 additions and 158 deletions.
diff --git a/.github/actions/integration-test/action.yml b/.github/actions/integration-test/action.yml
diff --git a/.github/workflows/integration-test-image.yml b/.github/workflows/integration-test-image.yml
diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml
@@ -20,7 +20,6 @@ jobs:
   build:
     name: Build
     runs-on: ubuntu-latest
-
     timeout-minutes: 20
 
     steps:
@@ -63,8 +62,19 @@ jobs:
     needs: build
     name: Test API
     runs-on: ubuntu-latest
+    timeout-minutes: 10
+    env:
+      DEBIAN_FRONTEND: noninteractive
 
     steps:
+      - name: Install dependencies
+        run: |
+          echo 'tzdata tzdata/Areas select Etc' | sudo  debconf-set-selections; \
+          echo 'tzdata tzdata/Zones/Etc select UTC' | sudo debconf-set-selections; \
+          sudo apt-get update && \
+          sudo apt-get install -y \
+          tzdata bats curl wget jq gnupg uuid-runtime
+
       - uses: actions/checkout@v3
 
       - uses: actions/download-artifact@v3
@@ -77,12 +87,11 @@ jobs:
         working-directory: bin/
 
       - name: Run API tests
-        uses: ./.github/actions/integration-test
-        with:
-          script: ./test/api.sh
+        run: ./test/api.sh
 
       - name: Upload the log
         uses: actions/upload-artifact@v3
+        if: ${{ always() }}
         with:
           name: api.log
           path: out.log
@@ -92,46 +101,19 @@ jobs:
     needs: build
     name: Test API (with authentication enabled)
     runs-on: ubuntu-latest
+    timeout-minutes: 10
+    env:
+      DEBIAN_FRONTEND: noninteractive
 
     steps:
-      - uses: actions/checkout@v3
-
-      - uses: actions/download-artifact@v3
-        id: download
-        with:
-          name: flipt
-          path: bin/
-
-      - run: chmod +x flipt
-        working-directory: bin/
-
-      - name: Run API tests
-        uses: ./.github/actions/integration-test
-        with:
-          script: ./test/api_with_auth.sh
-
-      - name: Upload the log
-        uses: actions/upload-artifact@v3
-        with:
-          name: api-with-auth.log
-          path: out.log
-          retention-days: 5
-
-  redis:
-    needs: build
-    name: Test Redis
-    runs-on: ubuntu-latest
-
-    services:
-      redis:
-        image: redis
-        options: >-
-          --health-cmd "redis-cli ping"
-          --health-interval 10s
-          --health-timeout 5s
-          --health-retries 5
+      - name: Install dependencies
+        run: |
+          echo 'tzdata tzdata/Areas select Etc' | sudo debconf-set-selections; \
+          echo 'tzdata tzdata/Zones/Etc select UTC' | sudo debconf-set-selections; \
+          sudo apt-get update && \
+          sudo apt-get install -y \
+          tzdata bats curl wget jq gnupg uuid-runtime
 
-    steps:
       - uses: actions/checkout@v3
 
       - uses: actions/download-artifact@v3
@@ -144,24 +126,33 @@ jobs:
         working-directory: bin/
 
       - name: Run API tests
-        uses: ./.github/actions/integration-test
-        with:
-          script: ./test/api.sh
-          config: "redis.yml"
+        run: ./test/api_with_auth.sh
 
       - name: Upload the log
         uses: actions/upload-artifact@v3
+        if: ${{ always() }}
         with:
-          name: redis.log
+          name: api-with-auth.log
           path: out.log
           retention-days: 5
 
   cli:
     needs: build
     name: Test CLI
     runs-on: ubuntu-latest
+    timeout-minutes: 10
+    env:
+      DEBIAN_FRONTEND: noninteractive
 
     steps:
+      - name: Install dependencies
+        run: |
+          echo 'tzdata tzdata/Areas select Etc' | sudo debconf-set-selections; \
+          echo 'tzdata tzdata/Zones/Etc select UTC' | sudo debconf-set-selections; \
+          sudo apt-get update && \
+          sudo apt-get install -y \
+          tzdata bats curl wget jq gnupg uuid-runtime
+
       - uses: actions/checkout@v3
 
       - uses: actions/download-artifact@v3
@@ -173,16 +164,32 @@ jobs:
         working-directory: bin/
 
       - name: Run CLI tests
-        uses: ./.github/actions/integration-test
-        with:
-          script: ./test/cli.bats
+        run: ./test/cli.bats
 
   ui:
     needs: build
     name: Test UI
     runs-on: ubuntu-latest
+    timeout-minutes: 10
+    env:
+      DEBIAN_FRONTEND: noninteractive
 
     steps:
+      - name: Install dependencies
+        run: |
+          echo 'tzdata tzdata/Areas select Etc' | sudo debconf-set-selections; \
+          echo 'tzdata tzdata/Zones/Etc select UTC' | sudo debconf-set-selections; \
+          sudo apt-get update && \
+          sudo apt-get install -y \
+          tzdata bats curl wget jq gnupg uuid-runtime && \
+          curl -sL https://deb.nodesource.com/setup_18.x | sudo bash - && \
+          sudo apt-get update && \
+          sudo apt-get install -y nodejs
+
+      - name: Install playwright
+        run: |
+          npx playwright install chromium --with-deps
+
       - uses: actions/checkout@v3
 
       - uses: actions/download-artifact@v3
@@ -194,6 +201,4 @@ jobs:
         working-directory: bin/
 
       - name: Run UI tests
-        uses: ./.github/actions/integration-test
-        with:
-          script: ./test/ui.sh
+        run: ./test/ui.sh
diff --git a/Dockerfile.it b/Dockerfile.it
diff --git a/test/api.sh b/test/api.sh
@@ -9,7 +9,7 @@ fi
 
 cd "$(dirname "$0")/.." || exit
 
-export SHAKEDOWN_URL="http://127.0.0.1:8080"
+export SHAKEDOWN_URL="http://0.0.0.0:8080"
 
 source ./test/helpers/shakedown/shakedown.sh
 
@@ -25,7 +25,7 @@ trap finish EXIT
 
 uuid_str()
 {
-    LC_ALL=C; cat /dev/urandom | tr -dc 'a-zA-Z0-9' | fold -w 16 | head -n 1
+    uuidgen
 }
 
 authedShakedown() {
@@ -316,7 +316,7 @@ run()
     echo -e "\e[32mStart testing $SHAKEDOWN_URL\e[0m"
     echo -e "\e[32m===========================================\e[0m"
 
-    ./test/helpers/wait-for-it/wait-for-it.sh "127.0.0.1:8080" -t 30
+    ./test/helpers/wait-for-it/wait-for-it.sh "0.0.0.0:8080" -t 30
 
     # allows api with auth to extract FLIPT_TOKEN from out log
     [[ $(type -t _api_test_hook) == function ]] && _api_test_hook

diff --git a/test/ui.sh b/test/ui.sh
@@ -27,7 +27,7 @@ run()
 
     sleep 5
 
-    flipt_host="127.0.0.1:${port}"
+    flipt_host="0.0.0.0:${port}"
 
     echo -e "\e[32m                \e[0m"
     echo -e "\e[32m===========================================\e[0m"