Images linting: ensure that all images conform specification #3802
Task list completed / task-list-completed
succeeded
Aug 7, 2024 in 0s
3 / 3 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
| Since there was substantial inconsistency in the background design of the icon assets, I took the effort to standardize all of these. Any icons with transparent/orange BG has been converted to pure monochrome black/white | Incomplete |
fbt: added lint_img, format_img targets for processing images |
Incomplete |
fbt: also added lint_all and format_all targets, invoking all linters and formatters |
Incomplete |
| github: now checking image formatting in linter workflow | Incomplete |
| Upon sideloading these icons, check any and all applications that utilize the changed icons. | Incomplete |
Check new targets, try adding images straight from image editors and run fbt lint_img |
Incomplete |
| PR has description of feature/bug or link to Confluence/Jira task | Completed |
| Description contains actions to verify feature/bugfix | Completed |
| I've built this code, uploaded it to the device and verified feature/bugfix | Completed |
Loading