-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images linting: ensure that all images conform specification #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyhawkillusions
requested review from
skotopes,
DrZlo13,
hedger and
gsurkov
as code owners
July 22, 2024 13:30
hedger
requested review from
nminaylov,
Skorpionm,
gornekich and
Astrrra
as code owners
July 22, 2024 14:01
I went on and re-processed all .png files in for f in `find assets applications -iname "*.png"`; do echo $f; magick $f -alpha off +profile "*" -define png:exclude-chunks=date,time -threshold "50%" -colors 2 $f.o && mv $f.o $f; done or find assets applications -iname "*.png" | xargs -P `getconf _NPROCESSORS_ONLN` -I F -n 1 sh -c 'mogrify -alpha off +profile "*" -define png:exclude-chunks=date,time -threshold "50%" -colors 2 F' |
2 tasks
…format_img` targets; github: integrated image lint step into CI
hedger
previously approved these changes
Aug 7, 2024
hedger
approved these changes
Aug 7, 2024
skotopes
approved these changes
Aug 7, 2024
skotopes
changed the title
Change all icons to be white background
Images linting: ensure that all images conform specification
Aug 7, 2024
ofabel
pushed a commit
to ofabel/flipperzero-firmware
that referenced
this pull request
Sep 26, 2024
…devices#3802) * Change all icons to be white background * assets: re-processed all *.png images to 1-bit * assets: also stripped profile data from .pngs * assets: also stripped datetime from metadata (`-define png:exclude-chunks=date,time`) * scripts: added image linter and formatter; fbt: added `lint_img` && `format_img` targets; github: integrated image lint step into CI * scripts: imglint: fixed deprecation warning * images: applied `format_img` * fbt: added `lint_all` and `format_all` targets; docs: updated for new targets Co-authored-by: hedger <[email protected]> Co-authored-by: hedger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
lint_img
,format_img
targets for processing imageslint_all
andformat_all
targets, invoking all linters and formattersVerification
fbt lint_img
Checklist (For Reviewer)