Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skylanders plugin #3315

Merged
merged 8 commits into from
May 15, 2024

Merge branch 'dev' into plugin_skylanders

a8e3113
Select commit
Loading
Failed to load commit list.
Merged

Skylanders plugin #3315

Merge branch 'dev' into plugin_skylanders
a8e3113
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded May 15, 2024 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
NFC Plugin to detect skylanders and show piece name (Need to add more from https://github.com/silicontrip/SkyReader/blob/master/toynames.cpp) Incomplete
Load Chest.nfc.txt onto flipper Incomplete
Open NFC app Incomplete
Select Saved->Chest->Info Incomplete
See "Skylanders" and "Imaginite Mystery Chest" (name from https://skylanders.fandom.com/wiki/Imaginite_Mystery_Chests) Incomplete
PR has description of feature/bug or link to Confluence/Jira task Completed
Description contains actions to verify feature/bugfix Completed
I've built this code, uploaded it to the device and verified feature/bugfix Completed
There is almost 0 cost to a feature, even if almost no one uses it. Incomplete
It clearly can be coded easily as a plugin, and requiring less work on my part than a full app Incomplete
I think, even if no new versions are coming out, skylanders was popular enough that it is likely examples of NFC the average person could have. Incomplete
There have been quite a few discussions about skylanders. This person (https://github.com/V0lk3n/Flipper-Skylanders) even went so far as wanting to add their figure specific keys to the global key list back in the day 😁 . Incomplete