Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skylanders plugin #3315

Merged
merged 8 commits into from
May 15, 2024
Merged

Skylanders plugin #3315

merged 8 commits into from
May 15, 2024

Conversation

bettse
Copy link
Contributor

@bettse bettse commented Dec 23, 2023

What's new

Verification

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger hedger added the NFC NFC-related label Dec 24, 2023
@Ethanol0001
Copy link
Contributor

This seems more than an app than a necessary plugin for the Flipper Zero. If you wish you can check out our Discord to see how to get started with making apps.

@bettse
Copy link
Contributor Author

bettse commented Dec 26, 2023

@Ethanol0001 That's sweet, but I'm Eric Betts. I wrote Seader and I'm co-author of the Picopass app.

@Ethanol0001
Copy link
Contributor

Ok but that doesn’t mean we need a feature that barely anyone uses anymore that would be better fitted if published to the flipper app store instead.

@bettse
Copy link
Contributor Author

bettse commented Dec 27, 2023

  1. There is almost 0 cost to a feature, even if almost no one uses it.
  2. It clearly can be coded easily as a plugin, and requiring less work on my part than a full app
  3. I think, even if no new versions are coming out, skylanders was popular enough that it is likely examples of NFC the average person could have.
  4. There have been quite a few discussions about skylanders. This person (https://github.com/V0lk3n/Flipper-Skylanders) even went so far as wanting to add their figure specific keys to the global key list back in the day 😁 .

@skotopes
Copy link
Member

@bettse need help?

@bettse bettse force-pushed the plugin_skylanders branch from 6fb568d to 50920c9 Compare April 20, 2024 02:16
@bettse
Copy link
Contributor Author

bettse commented Apr 20, 2024

Screenshot-20240419-191458

Tested again

@bettse bettse marked this pull request as ready for review April 20, 2024 02:19
@bettse bettse changed the title PoC skylanders plugin Skylanders plugin May 4, 2024
@gornekich gornekich self-assigned this May 15, 2024
@gornekich
Copy link
Member

gornekich commented May 15, 2024

Hi @bettse , thanks for PR!
Just want to confirm: all skylander tags has one password in 0 sector? There is no KDF?

@bettse
Copy link
Contributor Author

bettse commented May 15, 2024

Just want to confirm: all skylander tags has one password in 0 sector? There is no KDF?

Sector 0 is always the same; the other sectors are using a KDF

@gornekich
Copy link
Member

Sector 0 is always the same; the other sectors are using a KDF

Is that KDF known?

@bettse
Copy link
Contributor Author

bettse commented May 15, 2024

Is that KDF known?

yeah; it was published at https://nfc.toys/ and I think @noproto has worked on an implementation. That could be added to this later

@gornekich
Copy link
Member

Is that KDF known?

yeah; it was published at https://nfc.toys/ and I think @noproto has worked on an implementation. That could be added to this later

Got it, thanks!

@skotopes skotopes merged commit 50bee67 into flipperdevices:dev May 15, 2024
11 checks passed
@bettse bettse deleted the plugin_skylanders branch May 15, 2024 18:22
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request May 16, 2024
* PoC skylanders plugin
* based on db0c7e4
* More figures
* Fix util methods

Co-authored-by: あく <[email protected]>
Co-authored-by: gornekich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NFC NFC-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants