Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug when setting 'path_dir' in ComponentModeler #1990

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dmarek-flex
Copy link
Contributor

@dmarek-flex dmarek-flex commented Oct 1, 2024

Fixed a small bug that doesn't allow you to change the path_dir in the ComponentModeler. It is from a recent PR, so no changelog required.

@dmarek-flex dmarek-flex marked this pull request as ready for review October 1, 2024 19:47
Copy link
Collaborator

@weiliangjin2021 weiliangjin2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remind me why path_dir needs to match the internal values?

@dmarek-flex
Copy link
Contributor Author

dmarek-flex commented Oct 1, 2024

Could you remind me why path_dir needs to match the internal values?

Changes were made here. I think just to remain consistent and simplify. And also to predict where the BatchData is saved.

@dmarek-flex dmarek-flex merged commit a9defb5 into pre/2.8 Oct 2, 2024
15 checks passed
@dmarek-flex dmarek-flex deleted the dmarek/fix-path-dir-validation branch October 2, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants