ComponentModeler.batch_data and pathdir enhancements #1932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmarek-flex
approved these changes
Sep 9, 2024
|
Thanks @dmarek-flex . made the changes |
…ate passing path_dir to methods
tylerflex
force-pushed
the
tyler/smatrix/batch_data2
branch
from
fc5a233 to
48027ef
Compare
|
|
||
| ### Changed | ||
| - Priority is given to `snapping_points` in `GridSpec` when close to structure boundaries, which reduces the chance of them being skipped. | ||
| - Gradients for autograd are computed server-side by default. They can be computed locally (requiring more data download) by passing `local_gradient=True` to the `web.run()` and related functions. | ||
| - Passing `path_dir` to `ComponentModeler` methods is deprecated in favor of setting `ComponentModeler.path_dir` and will result in an error if the two don't match. |
There was a problem hiding this comment.
I don't exactly understand, do you mean pass path_dir when initializing ComponentModeler?
There was a problem hiding this comment.
ok: ComponentModeler(..., path_dir=actual_path_dir)
will warn: ComponentModeler.run(path_dir=different_path_dir)
There was a problem hiding this comment.
and will use actual_path_dir:
ComponentModeler.run()
There was a problem hiding this comment.
Ok, yeah, that's what I thought.
momchil-flex
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messed up rebase of #1918 so made a new PR