fix broken tvm integration caused by #568 #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsu-bin
force-pushed
the
fix_tvm_integration_rope
branch
from
a9e9667
to
3f16833
Compare
yzh119
approved these changes
Nov 5, 2024
yzh119
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, now tvm wrapper build failed cause by #568.
I noticed that the new
BatchQKApplyRotaryinterface removed__restrict__modifier fromDType* q, DType* k, DType* q_rope, DType* k_rope, so it's trivial to just add one adapter function to fix this issue.