-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken cpp integration caused by #567 #572
Conversation
@tsu-bin I verified your branch, and overall there are no major issues. This error wasn't introduced by you. Would it be convenient for you to fix it in the next PR? I'll merge this PR first. cc @yzh119 |
hi @zhyncs I will look into this issue later, I think this is less urgent, since tvm / mlc only rely on specific commit point. |
oops. Sorry for breaking cpp |
Sorry for the late reply, yes this PR fixes #571, thank you! |
|
Hi, cpp integration was broken again by #567, please be aware that there are cpp test, cpp benchmark and also tvm integration, they all relay on cmake build.