Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ansible to 10.7 and fix versions for all other packages. #51

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

ntwalibas
Copy link
Contributor

@ntwalibas ntwalibas commented Dec 17, 2024

Description

This PR upgrades ansible to 10.7.
It was previously set to 6.x. and stayed at that because of Pipfile.lock.
But that version has been deprecated and is now 2 years past end of life.

The PR also fixes versions for all other packages.

This PR solves one part of fjelltopp/fjelltopp-infrastructure#331, that is upgrading Ansible locally.

Dependency Changes

ALL the dependencies have had their versions fixed but two dependencies require special attention:

  • ansible has been upgraded to 10.7 so it is up-to-date with the version used in Azure.
  • requests has been kept <2.32 as per fjelltopp-ansible#34
  • resolvelib has also been upgraded to a version compatible with ansible 10.7.

Checklist

  • The Jira ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but a couple of thoughts about the comments

Pipfile Outdated Show resolved Hide resolved
Pipfile Outdated Show resolved Hide resolved
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntwalibas ntwalibas merged commit 4599b58 into master Dec 20, 2024
@ntwalibas ntwalibas deleted the upgrade/ansible branch December 20, 2024 14:45
Copy link

🚀 [bumpr] Bumped! New version:v3.1.0 Changes:v3.0.5...v3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants