Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade requests library #34

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Downgrade requests library #34

merged 1 commit into from
Oct 1, 2024

Conversation

mixmixmix
Copy link
Member

It seems that docker shipped with ansible collections (community.docker==3.3.2 most likely) is not compatible with requests 2.32. Downgrading to 2.31.

Of course we should update the collections...

More reading:
docker/docker-py#3256
ansible-collections/community.docker#863

Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From memory this might actually break things for me. Will test Monday and review then.

@ChasNelson1990 ChasNelson1990 self-requested a review September 27, 2024 20:52
Copy link
Member

@ChasNelson1990 ChasNelson1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on both ZaRR and AFRO locally with no issues.

@mixmixmix mixmixmix merged commit d7bd3dd into master Oct 1, 2024
@mixmixmix mixmixmix deleted the qfix-lib-requests branch October 1, 2024 15:07
Copy link

github-actions bot commented Oct 1, 2024

🚀 [bumpr] Bumped! New version:v1.3.2 Changes:v1.3.1...v1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants