Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/linkedin api updates 2023 #28

Merged
merged 19 commits into from
Mar 23, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing type field completely
fivetran-sheringuyen committed Feb 8, 2023

Verified

This commit was signed with the committer’s verified signature.
commit ee1271c31b19657829d1941ee28fbc306548487e
14 changes: 6 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,20 +2,18 @@
## 🚨 Breaking Changes 🚨
Due to Linkedin Ads API [change in January 2023](https://learn.microsoft.com/en-us/linkedin/marketing/integrations/recent-changes?view=li-lms-2022-12#january-2023), there have been updates in the Linkedin Ads Fivetran Connector and therefore, updates to this Linkedin package.

The following fields have been completely deprecated in the `stg_linkedin_ads__creative_history` model:
- `type`
- `call_to_action_label_type`
- `version_tag`
The following fields have been completely deprecated in the `stg_linkedin_ads__creative_history` model ([dbt_linkedin_source PR #48](https://github.com/fivetran/dbt_linkedin_source/pull/48)) and therefore removed from the below respective models in this package:
- `type` (removed from `*_creative_report`)
- `call_to_action_label_type` (removed from `*_creative_report`)
- `version_tag` (removed from `*_creative_report` and `*_url_report`)

## Updates
- `linkedin_ads__creative_report` now includes `campaign.type as campaign_type` as a proxy for the previously used `creative.type` field.
- `linkedin_ads__creative_report` no longer includes the fields `creative.version_tag`, `creative.type` and `creative.call_to_action_label_type`.
- `linkedin_ads__creative_report` now leverages `report.creative_id` instead of `creative.creative_id`.
- `linkedin_ads__campaign_report` now leverages `report.campaign_id` instead of `campaign.campaign_id`.
- `linkedin_ads__url_report` no longer includes the field `creative.version_tag` and now leverages `report.creative_id` instead of `creative.creative_id`.
- `linkedin_ads__url_report` now leverages `report.creative_id` instead of `creative.creative_id`.

## Under the hood
- `integration_tests/seed/linkedin_creative_history_data` has been updated to reflect new fields and deprecated fields updates
- `integration_tests/seed/linkedin_creative_history_data` has been updated to reflect new fields and deprecated field updates
- Legacy fields have been updated respectively in the connector and `dbt_linkedin_source v0.7.0` includes modifications that could affect the below fields within the `linkedin_ads__creative_history` model:
- `last_modified_at`
- `created_at`
1 change: 0 additions & 1 deletion models/linkedin_ads__creative_report.sql
Original file line number Diff line number Diff line change
@@ -45,7 +45,6 @@ final as (
campaign_group.campaign_group_name,
account.account_id,
account.account_name,
campaign.type as campaign_type,
creative.click_uri,
creative.status as creative_status,
campaign.status as campaign_status,