-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/linkedin api updates 2023 #28
Feature/linkedin api updates 2023 #28
Conversation
To-do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-sheringuyen The changes look good; however, I will hold off on approving until we get confirmation from the product team that these are good to roll out.
Additionally, I had a few super minor comments to address in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Very thorough change log :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me! Thanks again @fivetran-sheringuyen
❗ ❗
We are currently waiting for data to verify the updates before merging and releasing the changes in this PR. If you are currently using our Linkedin Package and would like to test out this version of the Package, we would love to hear about your experience. Please feel free to comment below and let us know what your experience is!
For those interested, you can test out this version by adding the below in your packages.yml and temporarily comment out your current version of
dbt_linkedin
.❗ ❗
Are you a current Fivetran customer?
Fivetran employee 💃
What change(s) does this PR introduce?
🚨 Breaking Changes 🚨
Due to Linkedin Ads API change in January 2023, there have been updates in the Linkedin Ads Fivetran Connector and therefore, updates to this Linkedin package.
The following fields have been completely deprecated in the
stg_linkedin_ads__creative_history
model:type
call_to_action_label_type
version_tag
Updates
linkedin_ads__creative_report
now includescampaign.type as campaign_type
as a proxy for the previously usedcreative.type
field.linkedin_ads__creative_report
no longer includes the fieldscreative.version_tag
,creative.type
andcreative.call_to_action_label_type
.linkedin_ads__creative_report
now leveragesreport.creative_id
instead ofcreative.creative_id
.linkedin_ads__campaign_report
now leveragesreport.campaign_id
instead ofcampaign.campaign_id
.linkedin_ads__url_report
no longer includes the fieldcreative.version_tag
and now leveragesreport.creative_id
instead ofcreative.creative_id
.Under the hood
integration_tests/seed/linkedin_creative_history_data
has been updated to reflect new fields and deprecated fields updatesdbt_linkedin_source v0.7.0
includes modifications that could affect the below fields within thelinkedin_ads__creative_history
model:last_modified_at
created_at
status
For more information, please refer to dbt_linkedin_source PR #48.
Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.