This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Update project configuration to remove Jellyfish references #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mironiasty
requested review from
karkakol and
graszka22
and removed request for
karkakol
karkakol
suggested changes
May 22, 2024
Package.swift
Outdated
| platforms: [ | ||
| .iOS(.v13) | ||
| ], | ||
| products: [ | ||
| // Products define the executables and libraries a package produces, and make them visible to other packages. | ||
| .library( | ||
| name: "JellyfishClientSdk", | ||
| targets: ["JellyfishClientSdk"]) | ||
| name: "FishjamClientSdk", |
There was a problem hiding this comment.
We should stick with the same name across package managers. On cocapods we have FishjamClient it should be named the same here.
There was a problem hiding this comment.
I updated it everywhere to match the naming.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all references in code to only use Fishjam. This include names in code, project names, build variables.
I also updated
protos, README and few other small things