Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Prepare code for releasing as a pod #19

Merged
merged 11 commits into from
May 27, 2024
Merged

Prepare code for releasing as a pod #19

merged 11 commits into from
May 27, 2024

Conversation

mironiasty
Copy link
Contributor

@mironiasty mironiasty commented May 21, 2024

This PR prepares code to be released as a pod.

  • update .podspec file to match new naming
  • update Starscream and SwiftPhoenixClient to latest version
    • update code to work with these versions
  • format README

@mironiasty mironiasty changed the title Prepare pod release Prepare code for releasing as a pod. May 22, 2024
@mironiasty mironiasty requested review from karkakol and graszka22 and removed request for karkakol May 22, 2024 07:55
@mironiasty mironiasty marked this pull request as ready for review May 22, 2024 07:55
@mironiasty mironiasty requested a review from karkakol May 22, 2024 07:55
@mironiasty mironiasty changed the title Prepare code for releasing as a pod. Prepare code for releasing as a pod May 22, 2024
Copy link
Member

@karkakol karkakol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging lets run e2e tests on react-native-cliend-sdk repo.
Another thing, yesterday you said that websocket client is not documented properly. Maybe we should change websocket package for another??


Pod::Spec.new do |s|
s.name = 'FishjamClient'
s.version = '0.3.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets have fresh start and change version to 0.1.0 or 1.0.0 if namespaces are changed and e2e tests from react-native repo pass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, this will make no real difference here. And repo already have 0.2.0 released. So I would have to remove old releases.
As for 1.0.0 - this SDK is not ready to have v1 released

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That release will not work because url and package name changed. It is strange for first package release to be versioned as 0.3.0 instead of 0.1.0 or 0.0.1. Release 0.2.0 should be removed because we do not want old releases here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That release will not work because url and package name changed
I don't understand - what will not work in this release? It is already working.

Release 0.2.0 should be removed because we do not want old releases here
What is the problem with old release? It is kind of historical release, and I don't see any issue with keeping it here. Between 0.2 and 0.3 we are just adding some new functionality into lib, it is not complete rewrite.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let it stay

@mironiasty
Copy link
Contributor Author

Before merging lets run e2e tests on react-native-cliend-sdk repo.

With all these changes, for me it makes much more sense to just run apps manually and do some manual testing for joining/disconnecting. There is a lot of things that can get broken during refactors, so we should do more detailed testing once we finish all refactors.

Another thing, yesterday you said that websocket client is not documented properly. Maybe we should change websocket package for another??

W can use any other lib - I don't have any preferences. I was finally able to migrate existing library. So let's how it is still working. If not - we can update it in next step.

@mironiasty mironiasty force-pushed the prepare-pod-release branch from c18a399 to e4bac22 Compare May 22, 2024 11:43
@karkakol
Copy link
Member

With all these changes, for me it makes much more sense to just run apps manually and do some manual testing for joining/disconnecting. There is a lot of things that can get broken during refactors, so we should do more detailed testing once we finish all refactors.

It can be manual testing but in this package example is small and incomplete. One resonable example app is in rn-client-sdk. If you link this repo in podfile and then test it manually it is great.

W can use any other lib - I don't have any preferences. I was finally able to migrate existing library. So let's how it is still working. If not - we can update it in next step.

If nothing breaks it can stay. We will see that in future.

@mironiasty
Copy link
Contributor Author

It can be manual testing but in this package example is small and incomplete. One resonable example app is in rn-client-sdk. If you link this repo in podfile and then test it manually it is great.

This change is already linked with rn-client-sdk. TBH example in this project has very similar functionality as the one in RN

Copy link
Member

@karkakol karkakol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mironiasty mironiasty merged commit 352d0cf into main May 27, 2024
1 check passed
@mironiasty mironiasty deleted the prepare-pod-release branch May 27, 2024 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants