add an add command #87
Conversation
mattlqx
force-pushed
the
add-command
branch
2 times, most recently
from
9e4a1ed to
5680201
Compare
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/fishi0x01/vsh/client" |
There was a problem hiding this comment.
CodeClimate complains that this import is redundant.
There was a problem hiding this comment.
Yeah, I'm not sure what it's on about there. It doesn't compile without it as client is used in the file.
There was a problem hiding this comment.
Interesting 🤔
Once you merge #88 and rebase, it will evaluate again. Lets see what it says then. If it fails again, I will take a look
There was a problem hiding this comment.
Ok. Still failing. I will have a look 👍
There was a problem hiding this comment.
Im not exactly sure what the issue here is. It seems to me that codeclimate uses a govet wrapper https://github.com/codeclimate-community/codeclimate-govet
Might be this is a bug. Running go vet . locally doesn't show any errors. I've marked the issue in CodeClimate as invalid
this command is basically `vault kv patch` but it's nice to have inside vsh when in interactive mode. you can simply add a key/value to a path. this can save you time if you're doing other operations inside vsh. i was also able to eliminate another duplication when creating new commands by making fetching the Command object from the Commands struct dynamic.
this command is basically
vault kv patchbut it's nice to have insidevsh when in interactive mode. you can simply add a key/value to a path.
this can save you time if you're doing other operations inside vsh.
i was also able to eliminate another duplication when creating new
commands by making fetching the Command object from the Commands struct
dynamic.