add output formatting option for replace command #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishi0x01
reviewed
Feb 22, 2021
| // final strings after replacement | ||
| replacedKey string | ||
| replacedValue string | ||
| } | ||
|
|
||
| // MatchOutput contains the possible ways of presenting a match |
There was a problem hiding this comment.
CodeClimate complains about formatting: Can you run gofmt -w cli/search.go?
my co-worker noted that its hard to share pastes of the replace commands dry-run output because its colorized. supporting a two-line output of changes with +/- prefixed to denote addition and subtraction for each change is better formatted for sharing. ``` ➜ build/vsh_darwin_amd64 -c 'replace -k value myValue KV1/src/a/foo -n' /KV1/src/a/foo> vmyValue = 1 Skipping write. ➜ build/vsh_darwin_amd64 -c 'replace -k value myValue KV1/src/a/foo -n -o diff' - /KV1/src/a/foo> value = 1 + /KV1/src/a/foo> myValue = 1 Skipping write. ```
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my co-worker noted that its hard to share pastes of the replace commands dry-run output because its colorized. supporting a two-line output of changes with +/- prefixed to denote addition and subtraction for each change is better formatted for sharing.