Update Dockerfile for clientapi PR #769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultimaweapon
previously approved these changes
Nov 13, 2019
There was a problem hiding this comment.
Step 4/9 : RUN apt-get update && apt-get install -y autoconf automake bsdmainutils ccache cmake curl g++ g++-mingw-w64-x86-64 gcc gcc-mingw-w64-x86-64 git libboost-all-dev libbz2-dev libcap-dev libdb4.8-dev libdb4.8++-dev libevent-dev libminiupnpc-dev libprotobuf-dev libqrencode-dev libssl-dev libtool libzmq3-dev make pkg-config protobuf-compiler python-pip qtbase5-dev qttools5-dev-tools python3-zmq libminizip-dev
---> Running in e60759068ad1
Get:1 http://ppa.launchpad.net trusty InRelease [15.4 kB]
Ign http://archive.ubuntu.com trusty InRelease
Get:2 http://security.ubuntu.com trusty-security InRelease [65.9 kB]
Get:3 http://archive.ubuntu.com trusty-updates InRelease [65.9 kB]
Get:4 http://ppa.launchpad.net trusty/main amd64 Packages [2955 B]
Hit http://archive.ubuntu.com trusty-backports InRelease
Get:5 http://security.ubuntu.com trusty-security/main amd64 Packages [1032 kB]
Hit http://archive.ubuntu.com trusty Release.gpg
Get:6 http://archive.ubuntu.com trusty-updates/main amd64 Packages [1460 kB]
Get:7 http://security.ubuntu.com trusty-security/restricted amd64 Packages [18.1 kB]
Get:8 http://security.ubuntu.com trusty-security/universe amd64 Packages [377 kB]
Get:9 http://archive.ubuntu.com trusty-updates/restricted amd64 Packages [21.4 kB]
Get:10 http://archive.ubuntu.com trusty-updates/universe amd64 Packages [671 kB]
Get:11 http://security.ubuntu.com trusty-security/multiverse amd64 Packages [4730 B]
Get:12 http://archive.ubuntu.com trusty-updates/multiverse amd64 Packages [16.1 kB]
Hit http://archive.ubuntu.com trusty Release
Hit http://archive.ubuntu.com trusty-backports/main amd64 Packages
Hit http://archive.ubuntu.com trusty-backports/restricted amd64 Packages
Hit http://archive.ubuntu.com trusty-backports/universe amd64 Packages
Hit http://archive.ubuntu.com trusty-backports/multiverse amd64 Packages
Hit http://archive.ubuntu.com trusty/main amd64 Packages
Hit http://archive.ubuntu.com trusty/restricted amd64 Packages
Hit http://archive.ubuntu.com trusty/universe amd64 Packages
Hit http://archive.ubuntu.com trusty/multiverse amd64 Packages
Fetched 3750 kB in 1s (1911 kB/s)
Reading package lists...
W: Size of file /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_binary-amd64_Packages.gz is not what the server reported 670555 670562
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package libminizip-dev
contrib/docker/builder/Dockerfile
Outdated
| @@ -9,7 +9,7 @@ RUN apt-get update && apt-get install -y \ | |||
| autoconf automake bsdmainutils ccache cmake curl g++ g++-mingw-w64-x86-64 gcc gcc-mingw-w64-x86-64 git \ | |||
| libboost-all-dev libbz2-dev libcap-dev libdb4.8-dev libdb4.8++-dev libevent-dev libminiupnpc-dev libprotobuf-dev \ | |||
| libqrencode-dev libssl-dev libtool libzmq3-dev make pkg-config protobuf-compiler python-pip qtbase5-dev \ | |||
| qttools5-dev-tools python3-zmq | |||
| qttools5-dev-tools python3-zmq libminizip-dev | |||
There was a problem hiding this comment.
Ubuntu 14.04 have no libminizip-dev.
There was a problem hiding this comment.
ok, I'm trying the Ubuntu 14 version. After I will squash the commits.
There was a problem hiding this comment.
Please dont squash after someone push a review. That make the reviewing be more difficult.
There was a problem hiding this comment.
Understand, but I also don't want to add a lot of small commits for the same feature. Anyhow, don't think we can push this
There was a problem hiding this comment.
still broken
Step 4/9 : RUN apt-get update && apt-get install -y autoconf automake bsdmainutils ccache cmake curl g++ g++-mingw-w64-x86-64 gcc gcc-mingw-w64-x86-64 git libboost-all-dev libbz2-dev libcap-dev libdb4.8-dev libdb4.8++-dev libevent-dev libminiupnpc-dev libprotobuf-dev libqrencode-dev libssl-dev libtool libzmq3-dev make pkg-config protobuf-compiler python-pip qtbase5-dev qttools5-dev-tools python3-zmq minizip
---> Running in 3db973fb7493
Get:1 http://ppa.launchpad.net trusty InRelease [15.4 kB]
Ign http://archive.ubuntu.com trusty InRelease
Get:2 http://ppa.launchpad.net trusty/main amd64 Packages [2955 B]
Get:3 http://security.ubuntu.com trusty-security InRelease [65.9 kB]
Get:4 http://archive.ubuntu.com trusty-updates InRelease [65.9 kB]
Hit http://archive.ubuntu.com trusty-backports InRelease
Get:5 http://security.ubuntu.com trusty-security/main amd64 Packages [1032 kB]
Hit http://archive.ubuntu.com trusty Release.gpg
Get:6 http://security.ubuntu.com trusty-security/restricted amd64 Packages [18.1 kB]
Get:7 http://security.ubuntu.com trusty-security/universe amd64 Packages [377 kB]
Get:8 http://archive.ubuntu.com trusty-updates/main amd64 Packages [1460 kB]
Get:9 http://security.ubuntu.com trusty-security/multiverse amd64 Packages [4730 B]
Get:10 http://archive.ubuntu.com trusty-updates/restricted amd64 Packages [21.4 kB]
Get:11 http://archive.ubuntu.com trusty-updates/universe amd64 Packages [671 kB]
Get:12 http://archive.ubuntu.com trusty-updates/multiverse amd64 Packages [16.1 kB]
Hit http://archive.ubuntu.com trusty-backports/main amd64 Packages
Hit http://archive.ubuntu.com trusty-backports/restricted amd64 Packages
Hit http://archive.ubuntu.com trusty-backports/universe amd64 Packages
Hit http://archive.ubuntu.com trusty-backports/multiverse amd64 Packages
Hit http://archive.ubuntu.com trusty Release
Hit http://archive.ubuntu.com trusty/main amd64 Packages
Hit http://archive.ubuntu.com trusty/restricted amd64 Packages
Hit http://archive.ubuntu.com trusty/universe amd64 Packages
Hit http://archive.ubuntu.com trusty/multiverse amd64 Packages
Fetched 3750 kB in 57s (65.0 kB/s)
Reading package lists...
W: Size of file /var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_trusty-updates_universe_binary-amd64_Packages.gz is not what the server reported 670555 670562
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package minizip
|
@thebevrishot It seems that minizip has been deprecated, from what I can tell it used to be in Trusty. As a result, we have two options:
|
|
Relevant PR: bitcoin/bitcoin#13171 |
added 2 commits
November 13, 2019 15:30
This reverts commit 227920a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
The clientapi PR will add the need for one more dependancy,
libminizip-dev. The Jenkins file for CI pulls from the remote Docker image and does not use the local one. So this PR adds the dependancy to the main dockerfile so that CI can pass onclientapi.An alternative solution is to get the Jenkins file to pull from the Dockerfile of the branch, though as it's a rare occurrence that it changes this way is probably ok.
(It should also be noted that the dependancy is only needed if the configure option
--enable-clientapiis set).