Change gitian-descriptors to use bionic instead #13171

ken2812221 · 2018-05-05T03:44:12Z

I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol:

test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0
test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27
qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0
qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27

I think this should be fixed in ./configure --enable-glibc-back-compat

Should not be merged before #13177 devrandom/gitian-builder#178

Close #12511

maflcko · 2018-05-05T14:16:39Z

Thanks! Concept ACK.

laanwj · 2018-05-07T12:56:54Z

Concept ACK

luke-jr · 2018-05-31T01:35:17Z

Need to be sure bionic images can be made for LXC, VirtualBox, and KVM. Last I checked there was an issue doing it for KVM :/

ken2812221 · 2018-05-31T03:05:48Z

It seems there is no more updates for python-vm-builder. @achow101 introduced a way to do gitian-build with docker, so I thought we could drop the KVM way if we couldn't find any patch to build KVM image. See #13368

maflcko · 2018-07-11T14:24:30Z

utACK 997816bcc7d59a3bdb68c677ef0a6bce00210aa0

This hopefully fixes the currently broken gitian windows cross compiles of the gui (qt 5.9.6)

theuni · 2018-07-12T18:54:15Z

contrib/gitian-descriptors/gitian-win.yml

@@ -93,6 +95,9 @@ script: |
    done
  done
  }
+  for i in $HOSTS; do


It should suffice to add a symlink from ${WRAP_DIR}/${i}/${i}-g++ to /usr/bin/${i}-g++-posix``` instead. Since this is in our path, that means that it would be picked up before the generic one.

theuni · 2018-07-12T18:54:47Z

doc/release-process.md

@@ -118,7 +118,7 @@ The gbuild invocations below <b>DO NOT DO THIS</b> by default.
    ./bin/gsign --signer "$SIGNER" --release ${VERSION}-linux --destination ../gitian.sigs/ ../bitcoin/contrib/gitian-descriptors/gitian-linux.yml
    mv build/out/bitcoin-*.tar.gz build/out/src/bitcoin-*.tar.gz ../

-    ./bin/gbuild --num-make 2 --memory 3000 --commit bitcoin=v${VERSION} ../bitcoin/contrib/gitian-descriptors/gitian-win.yml
+    ./bin/gbuild --allow-sudo --num-make 2 --memory 3000 --commit bitcoin=v${VERSION} ../bitcoin/contrib/gitian-descriptors/gitian-win.yml


This shouldn't be needed if the symlink trick works.

theuni · 2018-07-12T18:55:19Z

contrib/gitian-build.sh

@@ -281,7 +281,7 @@ then
 	    echo ""
 	    echo "Compiling ${VERSION} Windows"
 	    echo ""
-	    ./bin/gbuild -j ${proc} -m ${mem} --commit bitcoin=${COMMIT} --url bitcoin=${url} ../bitcoin/contrib/gitian-descriptors/gitian-win.yml
+	    ./bin/gbuild --allow-sudo -j ${proc} -m ${mem} --commit bitcoin=${COMMIT} --url bitcoin=${url} ../bitcoin/contrib/gitian-descriptors/gitian-win.yml


This also shouldn't be needed if the symlink trick works.

maflcko · 2018-07-12T19:44:41Z

contrib/gitian-descriptors/gitian-win.yml

@@ -2,7 +2,7 @@
 name: "bitcoin-win-0.17"
 enable_cache: true
 suites:
- "trusty"
+- "bionic"
 architectures:
 - "amd64"
 packages:


Should rename "git-core" to "git"?

Yes, I already do.

In line 11 of this file in the current version it still says "git-core", no?

Oh, I missed that one.

maflcko · 2018-07-13T01:48:27Z

re-utACK 5eaee74b6c2acae33f806fa60da757ea6fcbc689

theuni · 2018-07-13T04:09:23Z

ACK 5eaee74b6c2acae33f806fa60da757ea6fcbc689. I haven't tested the resulting binaries yet, but I can at least confirm that linux/macos/win build successfully.

I wrestled with Gitian and KVM/LXC all day to get it built, I'll write up some notes and work-arounds.

fanquake · 2018-07-15T12:35:47Z

utACK 5eaee74

LGTM There's a lot of work building on/ issues solved by this.

fanquake · 2018-07-16T07:16:54Z

@ken2812221 Could you please rebase this.

ken2812221 · 2018-07-16T10:43:33Z

@fanquake Rebased

fanquake · 2018-07-16T10:45:01Z

re-utACK c1afe32

c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f

Sjors · 2018-07-17T18:39:07Z

On Debian 9 I'm getting: "No such script: /usr/share/debootstrap/scripts/bionic"

As discussed on IRC, it's because debootstrap 1.0.92+ is required, but Debian 9 uses 1.0.89.

This means the current Gitian instructions for Debian 9 need to be updated for 0.17, e.g. to use Bionic instead, but there's some problems with that as well, see #13688.

maflcko · 2018-07-17T19:19:57Z

Indeed, would be nice to mention the minimum version of debbootstrap required for lxc builds.

theuni · 2018-07-17T19:30:28Z

@MarcoFalke As @achow101 pointed out on IRC, LXC usage doesn't require debootstrap.

The complication with LXC is that Bionic has moved to LXC3, and that causes problems if the Gitian builder is using LXC2. Gitian has very recent support for that thanks to @ken2812221, so make sure you upgrade Gitian to latest master before anything else.

The solution for me, on Xenial, was to enable xenial-backports and allow LXC3 to be installed from there.

maflcko · 2018-07-17T19:52:51Z

Ah, thanks for the input. In that case it should be removed from the programs that are installed

bitcoin/contrib/gitian-build.py

Line 16 in fa7f8a7

programs += ['lxc', 'debootstrap']

and probably a check added to assert lxc --version starts with 3, no?

theuni · 2018-07-17T20:07:48Z

Well, it kinda depends. lxc v3 isn't strictly required, it's only needed when building on Bionic if the host's lxc is < 2.1.1.

There's a bug in lxc 2.1.0 and below that causes incompatibility between v2 hosts and v3 guests. I believe it was fixed upstream by lxc/lxc@2c4bb8e.

See the ubuntu bug report here:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1760848

Unfortunately, those packages haven't been updated for Xenial, and likely won't be:
https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1776214

I have no clue about Debian or other distros.

So... I think the check should essentially be lxc-execute --version >= 2.1.1

jonasschnelli · 2018-07-19T20:53:27Z

I tried to upgrade my build host which is based on Debian and failed.

Since this requires LXC 2.1.1 or greater, it is currently not possible to run this on the newest version of Debian (9/stretch which currently has LXC in version 2.0.7).

Seems to be odd to drop out Debian as build host.... but maybe there are solutions to work around this (help welcome).

c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f

* Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings.

09df037 Mention minimum required version of lxc-execute (MarcoFalke) Pull request description: Source: bitcoin/bitcoin#13171 (comment) bitcoin/bitcoin#13991 (comment) Also remove the other options to create a docker host vm, since it wasn't updated for a couple of years. Tree-SHA512: 3bfcbccf594692adda1168e902a295cbeb6ac361ef86f405b31a953269571b668aafe9cafad9e39f16345f45b00d60de6b202cdfa3814a25f8c7aededa46ed93

karelbilek · 2018-10-14T14:44:34Z

I can confirm that because of this PR, you cannot gitian build on debian but you need to use ubuntu.

You can however use this

https://gist.github.com/laanwj/c62e101bfd68718f0686926dfd10666b

There is this PR that changes the build docs into ubuntu, which is another way of fixing that

bitcoin-core/docs#41

With either the ubuntu PR or the gist, it works (with some more changes)

* Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings.

* CSS margin for pages, sendcoins relocated structure, code cleaning * CSS sendcoins dialog form modified and bug fixed with purging overview CSS sendcoins dialog form modified removing a label from overview which is now in private * Bug fixed a not found font was being referenced * Removing unused code * Loading arrows and Fix for earlier versions of QT * CSS sendcoins dialog and entry modified * CSS sendcoinsdialog, sendcoinsentry, receivecoins and QDialog styles backgrounds dark color and transparencies * Styles changed for overview and statubar Unit display color on status bar Overview page: layout and USD labels * Private view layout and some style * Header section for socket message ui, testing Still testing ui overview css class implemented * Info icon on Private and Overview * Combo box style * Styles of combo box and gitignore updated Combo box not invading the tables, and disable mode * Header bar for socket message and testing ui for button * CSS header profile picture, still testing * SpinBox style and Table style * CSS recent transactions and dynamic text colors depending on theme If pac theme is set the white color will be the default for text. other wise it will be a dark text * Transaction bar at top of the tables * Personalized fonts and CSS Personalized fonts added and text colors for tables and lists * Private (background, button style), Send coins page (alignment). * CSS receivecoinsdialog positions and styles modified also tableview text color is now set as white * Send Coins page layout 90% * New customized fonts VolteRounded font for PAC * Bug fixed: Mistake writing qrc fixed * Send coins choose transaction fee moved and added a scroll area * Typography implemented on the code Volte Rounded * Default typography changed and new header bar Header bar for messages and profile picture implemented CSS, images, and elements ready to be programmed Application typography Volte Rounded is now the default for the wallet * Layout alignment * UI modifications Specific details * Receive Page background * Layout for bigger screens, checkbox added * Toolbar and headerbar Size modifed, CSS CSS of QToolButtons: - background when selected has changed - height and width QToolBar width Main Pac Icon modified and centered HeaderBar spacer added and select image changed * Proposal table layouts, private button and layout * custom ScrollBar implemented * Spinbox arrows layout, controls colors. * Global Button style fixed Border now transparent * Private colors and shadow, send margin * Receive coins link buttons and layout modifed spaces and margins * Background of dialog when closing app * Private_Overview functionality fix * Adding commas to make more easy to read large numbers * Re sorting buttons of tool bar menu and fixing disabled push button * Progress, unfinished components masternodes tab navigation label of masternodes addressbookpage table columns to be tested * remove border of Disabled link buttons * Private (info button, and sizes), SendPage (balance working) * Commas instead of spaces on bitcoinunits fixed bug there was a bug in where the negative quantities where not being converted properly * AddressBookPage and EditAddressDialog styles table styles modified inputs to fit with UI design * Receive layout and tables headers color * Masternodes and other css style * Table separations and overview layout test * No longer posible to set old theme "light" with GUI * Overview icon spacing, masternode lineedit style * new typography implemented gotham and Volte rounded Volte rounded: light, medium, semibold and bold gotham: medium and bold. * merge * style fixed with Gotham Medium typography family font was wrong * clocks and eyes icons * Overview info button * Checkbox and Radio button disable icon * Backend for the balance on the receive page * fix toolbar button height * Receive coins re-formulated * Image Picker beta 1 still testing * Receive page front end balance, and responsive layout * Combobox fix, overlay style, possible fix on receive send page * Merging headers on bitcoingui * Image picker now storage the image inside Paccoincore folder depending in each plataform the program will copy and paste the image selected, overwrite it if it exist and then each time the wallet loads it will choose the image from that path. The image will be copied where the .conf is located without file extention. Only allowed .xmp and .jpg images since .png files can't be loaded (QT bug apparently) * Bug fixed: img picker when cancelling button clicked if you were about to select an image from the file picker and decided to not select anything. When clicking cancel button the button would set the image as black. Now it keeps the last image. * Fix to the Private and overview displays * Amount on receive and send rearrange * New background, fix to info doubleclicked * Bug Fixed: AccentButton lost shape with small screens Sending coins page * Icons replaced accurate style and color correction * CSS Code optimization and combobox color fixed removing innecesary code and code that was being repeated CSS: - table header height fixed - arrow for sorting customized * Socket news connected only the half * Socket news working * Replaced icon editpaste * css header table * Getting the PAC USD value * QRC header file fix * Overview message info and PAC value send to the wallet frame * PAC value send to walletview * UI Fixes for small screens (send and receive page) * Unused code * PAC value using QSettings * QRCode implementation and restyle * Code mistake fixed forgot to delete it * QRCode on receivecoins size fixed * Show the USD value of your PACs * Overview message updated * USD PAC conversion validated * UI receive page minor fix for small screens * Wallet without sockets * QRC fix * make include FIX * Bitcoin amount field FIX Not working with commas. * update-deps * add patches * PACtoUSD removal * BugFixed with BitcoinAmountField comma the spinner was not detecting the amount with the comma. It was removed from this control * Amperson removed from ui * RCC was not finding the icons and assets It should work now * completion * Add dmg background * macdeploy missing files * Change tar.gz name * update-deps * add patches * completion * Add dmg background * macdeploy missing files * Change tar.gz name * Migrate macdeploy to python3 * Change tar.gz name on gitian descriptors. * Auto stash before merge of "socket_semoval" and "origin/socket_semoval" * Change windows setup filename * asset correction removed unused image. Replaced format jpg to png on background * UI BugFixed Style now is default. Removed unused code. Button icons removed from linux and windows. * jpg to png background fix * profile img removed from make.qt.include * Auto stash before merge of "socket_semoval" and "origin/socket_semoval" * asset correction removed unused image. Replaced format jpg to png on background * UI BugFixed Style now is default. Removed unused code. Button icons removed from linux and windows. * jpg to png background fix * profile img removed from make.qt.include * News message deleted * Icons on Windows deleted * Scrollbar horizontal ui fixed * BugFixed a comma unwanted * restoring cross platform functionality of icons on buttons was already disabled * Overview info updated and dialog URI background changed * MyMasternodes table style fix * GCC-7 and glibc-2.27 compat code * Add stdin, stdout, stderr to ignored export list * Backport move to Ubuntu Bionic and GCC7 in Gitian builds (dashpay#2225) * Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings. * BugFixed: Table borders on windows and linux now transparent border:none; * Private page tool tip fix * BugFixed UI send and receive coins When coins control dialog open. right colum was getting small. Sendcoins page: coins control re located. Table of history requested coins was too small in height. QRCode address otput implementation (pending to finish) * Sign/Verify message, base for news with an API * CSS Qtooltip custom style * CSS QProgressBar and QuickButton class rounded corners. * Receive coins Address hidden for default, visible after requesting payment. Copy to clipboard button. * BugFixed: Toolbar can't be hide now It was able to be hide without being able to show it again * proposal table> Fixing width of the tables width of first column of tables was too small. * BugFixed: href color changed to easy read * Animated QRCode and Address UX in order to make the user able to notice when is changing. Tableview row will be focused too * Syncing with master branch (#1) * Delayed block penalization and new reward percentages (#66) * Delayed block penalization (#62) - Delayed block penalization - Reset regtest - Change protocol version - Update blockdelay RPC test. - Fix min chain work on regtest chain params. - Add chain penalization field to getchaintips method. - Fix log formating * New reward percentages 70215 (#63) Changing the reward percentages, miners now get 15% and masternodes get 65%. * Change activation block height for new rewards * Bump min protocol and new checkpoint (#65) - Min protocol version is now 70215 - Bumped the version on the masternode update scripts. - Added a checkpoint, block `#216000`. * Update README.md, adding the PacNodesUpdater instructions (#67) * Update README.md * Added PacNodesUpdater script * Update README.md * Update README.md * Update README.md * Update README.md * Update PAC_update.sh (#68) Changed the update complete text to get people to start from cold wallet. * Update pac-update.sh (#69) * CSS UI BugFixed Buttons width larger to fit content text, LineEdit for pac address larger for easy to read (on requesting coins). * UI send and receive coins spacer for the hidden fees features so it fits the scrollarea. Buttons size and margins LineEdit class changed * Fixes and News/pac-usd -Update news -Update pac-usd value (only overview) -info on overview updated of where we get the pac-usd value -Copy news button -Unused code deleted * UI fixed * Update send and receive labels for USD * Options dialog label warning fixed size * html <a> href style from blue to yellow * News pointing to the right API * Tooltips for copy and refresh news * Background and selection bar colors * General backgrounds and text inputs colors changed To have a better contrast on the elements and text. * CSS send coins, progressbar, check and radiobutton merging branches v1.2 to 1.3 radiobutton, checkbutton with spaces layouts modified * Top bar color darker * Qslider customized and sendcoinsdialog * Fix typo * "Pay to" recipient separator * new mined icon * Tables have more colors to make it prettier * Qslider css, recent transactions font size, pac to usd width * Optimizing CSS, layouts fixed removing btnCopyNews and btnRefreshNews styles, using QuickButton instead. Replaced QPushButton to QToolButton * Unnecessary code * Masternode table white text * Master nodes Table not enabled text to red * Pixel Size font trying to fix windows dpi font issues * CSS and layout fixing QRCode and other forms layout now fixed sizes in order to fit properly * Button to copy the conversion of USD-PAC * AddressBookPage table fix text color * Private page advance mode ui fixes Red color to bright, buttons not align and progress bar not center. * Masternodes Page tabs color and size change * Coin control dialog UI fixes Style of the table, white borders, and cut labels. * Translations fix German and Spanish * SendCoins CoinControl scrollbar and better displaying * Possible fix for windows On preferences the tabs go out on the left * User can now select typography cuz it was hurting users eyes * Custom Font Typo Now the user can select any typography installed on the system. In addition to the default ones for the UI * News feed can show a longer text * Radio button color change * Some documentation for the code * Code reorganization and comments * Merge, QFont, QRCode QRcode will resize on small and big screens * QRCode BugFixed it was stretching a lot. Now it will respect the layout * QRCode resized fixed When the button was clicked it was not setting the window. height * Light theme start of typo and backgrounds. * CSS and UI Bug fixed - Background Image now resize keeping aspect ratio. - Profile Image button now is capable of restoring original pac logo/changing the current image. - purging code (removing std::cout debbugers) - BugFixed: sendcoinsentry address typography was different, now it takes the selected font for the wallet. - BugFixed: receive coins page, the form was being cropped on small screens, changed the layouts and min height. - * Test * Private Page message corrupting the view on small devices. * Modal Overlay UI modification * margin on private page label * profile img button bug fixed it was starting blank (attempting) * Tab bar and color palette changed * Trying to fix Font problems default pac font to be selected automatically * Font size now medium in order to make it more readable * Fix of my failed merge * trying to fix font default * Custom Font Bug Fixed Now the font will be medium. Code optimized. * Using alias and CSS Black and grey * Bug Fixed> The checkboxes on receive coins page were squeezing * Fixing contrast of ui elements including the toolbar selected button and the inputs * SendCoins page "Fee" fix decimals * Micro sign on Overview fix * Micro sign on Private Page fix * bitcoinamount field changed in order to be fixed on height * separator implemented On send coins page -> the text inputs were too close. A separator should fix this issue presented only on windows. * ui fixed * Typography fixing * Fig compilation error due to qt version this property can not be compiled * New icon colors, images added on css now and table colors change * UI enhancement * CSS Light theme changes * Revert "Merge branch 'new-ui_v1.5white' into new-ui_v1.4" This reverts commit 2e2c5de.

* Add stdin, stdout, stderr to ignored export list * Merge bitcoin#13171: Change gitian-descriptors to use bionic instead c1afe32 Change gitian-descriptors to use bionic instead (Chun Kuan Lee) Pull request description: I have tested this with Ubuntu Bionic host with lxc 3.0.0, the gitian-build for Windows and MacOSX work fine, but there is an issue about it for Linux. Failed at check-symbol: ``` test/test_bitcoin: symbol __divmoddi4 from unsupported version GCC_7.0.0 test/test_bitcoin: symbol log2f from unsupported version GLIBC_2.27 qt/bitcoin-qt: symbol __divmoddi4 from unsupported version GCC_7.0.0 qt/bitcoin-qt: symbol log2f from unsupported version GLIBC_2.27 ``` I think this should be fixed in `./configure --enable-glibc-back-compat` Should not be merged before bitcoin#13177 devrandom/gitian-builder#178 Close bitcoin#12511 Tree-SHA512: 257d75d5b6864e105279f7a7b992fbbd7903cdbe3300b66dacec0a783d267707d9dbbfe0e64a36983ca1eca50a2a5e1cdb222b6d3745ccc3e5fc5636c88b581f * Use IN6ADDR_ANY_INIT instead of in6addr_any This is the same fix as bitcoin/bitcoin@fc6a9f2 Couldn't backport the original commit as we are missing some refactorings.

Implemented a version of these pull requests from upstream: bitcoin/bitcoin#13177 bitcoin/bitcoin#13171

This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171), and that has a far newer version of binutils. binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

…escriptor bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake) Pull request description: This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900). However, it should no longer be required, as we have switched to Bionic (#13171) and that has a far newer version of binutils. Original discussion: #6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 ACKs for top commit: MarcoFalke: ACK bd3f5a9 theuni: ACK bd3f5a9 laanwj: ACK bd3f5a9 Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c

…itian descriptor bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake) Pull request description: This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that has a far newer version of binutils. Original discussion: bitcoin#6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 ACKs for top commit: MarcoFalke: ACK bd3f5a9 theuni: ACK bd3f5a9 laanwj: ACK bd3f5a9 Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c

This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171), and that has a far newer version of binutils. binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

fanquake added the Build system label May 5, 2018

fanquake requested a review from theuni May 5, 2018 03:59

maflcko added this to the 0.17.0 milestone May 31, 2018

ken2812221 changed the title ~~[WIP] Change gitian-descriptors to use bionic instead~~ Change gitian-descriptors to use bionic instead Jun 2, 2018

This was referenced Jul 10, 2018

Migrate gitian-build.sh to python #13623

Merged

gitian-build.sh cleanup #13628

Closed

maflcko assigned theuni Jul 11, 2018

DrahtBot mentioned this pull request Jul 12, 2018

Switch to NSIS 3.03 to avoid DLL hijacking #13643

Closed

theuni reviewed Jul 12, 2018

View reviewed changes

DrahtBot added the Needs rebase label Jul 12, 2018

maflcko reviewed Jul 12, 2018

View reviewed changes

DrahtBot removed the Needs rebase label Jul 13, 2018

ken2812221 mentioned this pull request Jul 15, 2018

[build] Add risc-v support to gitian #13665

Merged

Change gitian-descriptors to use bionic instead

c1afe32

laanwj merged commit c1afe32 into bitcoin:master Jul 16, 2018

ken2812221 deleted the gitian branch July 16, 2018 10:55

Sjors mentioned this pull request Jul 17, 2018

Gitian with Bionic host #13688

Closed

Sjors mentioned this pull request Jul 18, 2018

Gitian crash for ARM compiling BDB depends (Bionic host) #13700

Closed

Bushstar mentioned this pull request Jul 19, 2018

commits from bitcoin/master FeatherCoin/Feathercoin#356

Merged

maflcko mentioned this pull request Aug 26, 2018

Gitian Build issue on Ubuntu host (LXC is missing the - - name option) #14068

Closed

maflcko mentioned this pull request Sep 6, 2018

Mention minimum required version of lxc-execute bitcoin-core/docs#38

Merged

CryptAxe added a commit to DriveNetTESTDRIVE/DriveNet that referenced this pull request Jun 10, 2019

Update gitian build, glibc back compat, cleanup

240b580

Implemented a version of these pull requests from upstream: bitcoin/bitcoin#13177 bitcoin/bitcoin#13171

fanquake mentioned this pull request Aug 20, 2019

build: remove mingw linker workaround from win gitian descriptor #16667

Merged

riordant mentioned this pull request Nov 13, 2019

Update Dockerfile for clientapi PR firoorg/firo#769

Closed

bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change gitian-descriptors to use bionic instead #13171

Change gitian-descriptors to use bionic instead #13171

ken2812221 commented May 5, 2018 •

edited

Loading

maflcko commented May 5, 2018

laanwj commented May 7, 2018

luke-jr commented May 31, 2018

ken2812221 commented May 31, 2018 •

edited

Loading

maflcko commented Jul 11, 2018

theuni Jul 12, 2018

theuni Jul 12, 2018

theuni Jul 12, 2018

maflcko Jul 12, 2018

ken2812221 Jul 12, 2018

maflcko Jul 12, 2018

ken2812221 Jul 12, 2018

maflcko commented Jul 13, 2018

theuni commented Jul 13, 2018

fanquake commented Jul 15, 2018

fanquake commented Jul 16, 2018

ken2812221 commented Jul 16, 2018

fanquake commented Jul 16, 2018

Sjors commented Jul 17, 2018

maflcko commented Jul 17, 2018 •

edited

Loading

theuni commented Jul 17, 2018

maflcko commented Jul 17, 2018

theuni commented Jul 17, 2018

jonasschnelli commented Jul 19, 2018

karelbilek commented Oct 14, 2018 •

edited

Loading

Change gitian-descriptors to use bionic instead #13171

Change gitian-descriptors to use bionic instead #13171

Conversation

ken2812221 commented May 5, 2018 • edited Loading

maflcko commented May 5, 2018

laanwj commented May 7, 2018

luke-jr commented May 31, 2018

ken2812221 commented May 31, 2018 • edited Loading

maflcko commented Jul 11, 2018

theuni Jul 12, 2018

Choose a reason for hiding this comment

theuni Jul 12, 2018

Choose a reason for hiding this comment

theuni Jul 12, 2018

Choose a reason for hiding this comment

maflcko Jul 12, 2018

Choose a reason for hiding this comment

ken2812221 Jul 12, 2018

Choose a reason for hiding this comment

maflcko Jul 12, 2018

Choose a reason for hiding this comment

ken2812221 Jul 12, 2018

Choose a reason for hiding this comment

maflcko commented Jul 13, 2018

theuni commented Jul 13, 2018

fanquake commented Jul 15, 2018

fanquake commented Jul 16, 2018

ken2812221 commented Jul 16, 2018

fanquake commented Jul 16, 2018

Sjors commented Jul 17, 2018

maflcko commented Jul 17, 2018 • edited Loading

theuni commented Jul 17, 2018

maflcko commented Jul 17, 2018

theuni commented Jul 17, 2018

jonasschnelli commented Jul 19, 2018

karelbilek commented Oct 14, 2018 • edited Loading

ken2812221 commented May 5, 2018 •

edited

Loading

ken2812221 commented May 31, 2018 •

edited

Loading

maflcko commented Jul 17, 2018 •

edited

Loading

karelbilek commented Oct 14, 2018 •

edited

Loading