refactor: use viewbinding instead of findViewById() or Synthetic Binding #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rosariopfernandes nice! Want to pick some of these and assign them to me? That way we can split up the work and I will also get experience with viewBinding. |
|
@samtstern That'd be great! Feel free to pick any of them and assign it to yourself. I'm not working on any of them at the moment, but I'll get to it in a few hours. |
|
@rosariopfernandes ok I took a few to start (I think they're big ones so I didn't take that many) |
|
@rosariopfernandes sorry for my lag here I have got pulled into a crazy project and am not able to work on any of the normal samples/libraries for a few days. I will still do my part as soon as I can! |
|
@samtstern no worries! Something similar happened to me. Although I'm
excited to see View Binding being implemented here, there's no rush to put
this out there.
…On Wed, 15 Apr 2020 at 16:08, Sam Stern ***@***.***> wrote:
@rosariopfernandes <https://github.com/rosariopfernandes> sorry for my
lag here I have got pulled into a crazy project and am not able to work on
any of the normal samples/libraries for a few days. I will still do my part
as soon as I can!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1096 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD75OBVRSK5TJ4FNZZV7UTDRMW5XVANCNFSM4MEHSURA>
.
--
*Rosário Pereira Fernandes*
*________________________________*
• Co-Organizer @ GDG Maputo <https://www.meetup.com/GDG-Maputo/>
• <https://www.credential.net/9a5bf0e6-f5a9-4552-9b9a-e84c7b821c09>Associate
Android Developer (Kotlin)
<https://www.credential.net/9a5bf0e6-f5a9-4552-9b9a-e84c7b821c09>
• Twitter: @_rpfernandes <https://twitter.com/_rpfernandes>
• Linkedin: rosariopfernandes
<https://www.linkedin.com/in/rosariopfernandes/>
*[image: Android Associate Developer]
<https://www.credential.net/9a5bf0e6-f5a9-4552-9b9a-e84c7b821c09>*
|
thatfiredev
force-pushed
the
rpf-implement-viewbinding
branch
from
4ccddfe to
117a53e
Compare
Change-Id: Iaf93ea054f1647756ca508588f4d1ea9471b82fe
Change-Id: If02639504b35bf9be3da9d0e89713c5d97fe6bff
Change-Id: Ib4bc037abba4629f1bebf787e754a7b2da840b12
Change-Id: Id73cfc9b0a0ad81171f447b3e6e0fccc7f2440d0
Change-Id: I72ba385a8e03451ab005ee4e9a3a03c076dec391
Change-Id: Iba584a1ef9aba6a55d0fc2d0a8ae1feedc6f94a3
|
@rosariopfernandes thank you so much for leading the charge here! If the build goes green I am gonna merge. |
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP until view binding is implemented in all of our samples:@rosariopfernandes TODO list
@samtstern TODO list
Closes #1088