Suggestion: Use View Binding instead of synthetic binding and findViewById

[thatfiredev]

(Our bot will not be happy with this issue)

Now that we're using Gradle 3.6.1, we could enable View Binding on our samples. Two reasons why I would recommend this change:

• Kotlin synthetic binding is not recommended;
• ViewBinding removes the need for findViewById, which would make our app implementation simpler, since it's meant for demonstration purposes.

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[samtstern]

@rosariopfernandes oh that's really cool! I had no idea this was available. I never liked Kotlin synthetic binding but I was trying to be one of the Kotlin Cool Kids 😎

[thatfiredev]

Hahah, I see. Does that mean this is a go?

[samtstern]

Do we need to use any alpha/beta tooling or is this all powered by AGP 3.6.1 stable? If it's stable I'm good to go with this but I don't want our devs to have to use AS Canary or anything like that.

…

On Thu, Mar 26, 2020, 11:19 AM Rosário Pereira Fernandes < ***@***.***> wrote: Hahah, I see. Does that mean this is a go? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1088 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACATB2R23CEKG437N77NFALRJNW6JANCNFSM4LUJVK7A> .

[thatfiredev]

ViewBinding is included in 3.6.1 stable. No need to use any alpha/beta tools.

[samtstern]

Ok then let's do it!

…

On Thu, Mar 26, 2020 at 11:30 AM Rosário Pereira Fernandes < ***@***.***> wrote: ViewBinding is included in 3.6.1 stable. No need to use any alpha/beta tools. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1088 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACATB2S2OFL4IXU26FNW323RJNYIDANCNFSM4LUJVK7A> .

[gaglileo]

I have noticed that using ViewBinding, the camera in Kotlin MLKit sample app is finally working

[thatfiredev]

@samtstern As I was implementing this, I noticed that some of our layouts only contain a single view (e.g. analytics/fragment_main.xml). I think for these cases it's simpler to use findViewById() instead of View Binding, since the number of lines will remain the same and we'll actually have less binding classes being generated by the plugin during build.
Unless we want to use View Binding in all views for consistency. WDYT?

[samtstern]

@rosariopfernandes I don't have a strong opinion here, I think either choice you could make for a single-view layout is a reasonable one! Whatever you think looks best as you implement is fine with me.