feat(firebase_core, android): bump Android BoM to v25.13.0, fix firebase_ml_vision build #4330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The last commit from #4331 fixed builds on firebase_ml_vision for firebase-android-sdk >= 25.13.0
024a11c
It was part of this PR originally but was committed already, so this PR is now just bumping the SDK to latest stable before the firebase-android-sdk v26.x.x breaking change
Original PR rationale here:
Specifically, these BoMs are documented upstream to not contain the correct dependencies, and because they are deprecated (and then removed in later BoMs) there is no fix coming.
This workaround is the only way to allow for the module to compile and be used
This is identical to the work done in react-native-firebase: invertase/react-native-firebase@dc4f57a#diff-8a85188c69631f3ee1d3b09e01cdfcffae515432e9efdfb74683b880a8902172
And the upstream notes are here:
Bumping the android version would be a breaking change if we did not include the dependencies in the module as we do here
Related Issues
This is part of #4249 but these 2 commits may be considered and adopted both independently and immediately, helping users and shrinking that PR to it's core purpose.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?