Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_core, android): bump Android BoM to v25.13.0, fix firebase_ml_vision build #4330

Merged

Conversation

mikehardy
Copy link
Contributor

@mikehardy mikehardy commented Dec 4, 2020

Description

The last commit from #4331 fixed builds on firebase_ml_vision for firebase-android-sdk >= 25.13.0

024a11c

It was part of this PR originally but was committed already, so this PR is now just bumping the SDK to latest stable before the firebase-android-sdk v26.x.x breaking change

Original PR rationale here:


Specifically, these BoMs are documented upstream to not contain the correct dependencies, and because they are deprecated (and then removed in later BoMs) there is no fix coming.

This workaround is the only way to allow for the module to compile and be used

This is identical to the work done in react-native-firebase: invertase/react-native-firebase@dc4f57a#diff-8a85188c69631f3ee1d3b09e01cdfcffae515432e9efdfb74683b880a8902172

And the upstream notes are here:

Bumping the android version would be a breaking change if we did not include the dependencies in the module as we do here

Related Issues

This is part of #4249 but these 2 commits may be considered and adopted both independently and immediately, helping users and shrinking that PR to it's core purpose.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@google-cla google-cla bot added the cla: yes label Dec 4, 2020
@mikehardy mikehardy changed the title fix(firebase_ml_vision, android): fix build for Android BoM v25.13 feat(firebase_core, android): bump Android BoM to v25.13.0, fix firebase_ml_vision build Dec 4, 2020
@mikehardy mikehardy force-pushed the android_ml_vision_build_fixes_v25.13 branch from 39c722d to a976711 Compare January 4, 2021 19:09
@Salakar Salakar merged commit 7524534 into firebase:master Jan 4, 2021
@mikehardy mikehardy deleted the android_ml_vision_build_fixes_v25.13 branch January 4, 2021 23:05
@firebase firebase locked and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants