-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: forward port to firebase-ios-sdk v7+ / firebase-android-sdk v26+ #4249
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
This comment has been minimized.
This comment has been minimized.
c6724aa
to
c94b8e9
Compare
@Salakar / @Ehesp this is ready for review, I believe iOS and Android are both working now, should clear the way for auth emulator as a quick followon I understand there may be concurrent work with regards remote-config port, happy to coordinate on that though I was very very light with regards to my forward-port treatment of it here and kept the commits pretty granular so it should be easy to deal de-conflict / integrate |
GitHub actions aren't wrapped in retry so the android gradle ones flake without recovering as they attempt to pull remote dependencies. Something like this would fix it though it will need to be flutter-ified invertase/react-native-firebase@f1b9af9 Here's a first cut at de-flaking E2E: #4265 One of the storage tests flaked for ios, it's passed before during this PR development and passes locally so should be unrelated to the commit:
If you retry both (I don't have permission) it should go green after one or two attempts, they work locally each time |
c94b8e9
to
07c9c55
Compare
packages/firebase_remote_config/example/test_driver/firebase_remote_config_e2e.dart
Show resolved
Hide resolved
07c9c55
to
713cafb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahoy @mikehardy, looking good, just a couple of minor points that I think might be an issue.
packages/firebase_remote_config/ios/Classes/FirebaseRemoteConfigPlugin.m
Show resolved
Hide resolved
packages/firebase_remote_config/ios/Classes/FirebaseRemoteConfigPlugin.m
Outdated
Show resolved
Hide resolved
packages/firebase_remote_config/example/test_driver/firebase_remote_config_e2e.dart
Show resolved
Hide resolved
713cafb
to
d5d9a60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is aligned with firebase-ios-sdk v7 requirements Example projects' deployment targets bumped to 10
remote-config debugMode is removed, use minimumFetchInterval instead this should work on ios and android platforms
one symbol in underlying native code changed, but this is not breaking, the previous commit to move firebase-ios-sdk contained the only breaking change that was visible in the Dart code / Flutter API
d5d9a60
to
276dc9d
Compare
Description
This is a forward port of FlutterFire to firebase-ios-sdk v7+ and firebase-android-sdk v26+
Each commit may be viewed in isolation, and in fact that is recommended.
Related Issues
Unsure if there are other issues to relate but:
#4013 - updating to SDK26 for firestore
#3969 - auth useEmulator discussion - it is gated on this but is trivial once the forward port is done
Checklist
This is my first Dart code, first Flutter code, and first batch of FlutterFire PRs
I did the same port for react-native-firebase though, so I'm new here but have been in the area a lot. Be gentle ;-)
I am not sure what should be done in the CHANGELOG or with regard to version numbers here.
///
).flutter analyze
) does not report any problems on my PR.Breaking Change
iOS minimum deployment target is moved to 10+
RemoteConfig debugMode no longer exists. minimumFetchTime / fetchTimeout replace it