Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fis modularization #3751

Merged
merged 28 commits into from
Sep 17, 2020
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
8b42af1
copied orginal FIS sdk into packages-expp and made unit tests passed
ChaoqunCHEN Aug 13, 2020
41cd275
migrated test app and fixed a test app bug to make it worked
ChaoqunCHEN Aug 13, 2020
4947925
made installations-exp depend on app-exp
ChaoqunCHEN Aug 13, 2020
a67daa4
Relocated public methods files into folder
ChaoqunCHEN Aug 13, 2020
5d5001a
Making installations mudularization step1, build success
ChaoqunCHEN Aug 14, 2020
3aa24dd
Making installations mudularization step2, unit tests pass
ChaoqunCHEN Aug 14, 2020
39c39eb
update dependency version, merge master
ChaoqunCHEN Aug 14, 2020
0af33d4
Merge branch 'master' into fis-modularization
ChaoqunCHEN Aug 14, 2020
bbc121c
Apply suggestions from code review
ChaoqunCHEN Aug 25, 2020
93e1215
update dependencies' version
ChaoqunCHEN Aug 25, 2020
9570f71
Merge branch 'master' into fis-modularization
ChaoqunCHEN Aug 25, 2020
aa2c9a0
add getInstallation(app)
ChaoqunCHEN Aug 26, 2020
e2a1930
correct deleteInstallations funciton name
ChaoqunCHEN Aug 26, 2020
9b46a8f
Place the call to registerVerion and registerInstallations at the sam…
ChaoqunCHEN Aug 26, 2020
36e93da
remove dead code
ChaoqunCHEN Aug 26, 2020
3d3d36c
add api extractor config
ChaoqunCHEN Aug 26, 2020
8e36c93
rewrite the internal interface
ChaoqunCHEN Aug 26, 2020
be162a3
Merge branch 'master' into fis-modularization
ChaoqunCHEN Aug 26, 2020
4aa04bc
fix build error
ChaoqunCHEN Aug 26, 2020
ce48439
Seperate internal interface from public interface.
ChaoqunCHEN Sep 1, 2020
1df33cc
Change public methods to accept public interface
ChaoqunCHEN Sep 2, 2020
19bab1c
Merge branch 'master' into fis-modularization
ChaoqunCHEN Sep 2, 2020
5876ea8
Fixes and api extractor integration for @firebase/installations-exp (…
Feiyang1 Sep 2, 2020
2b554a2
merge master
ChaoqunCHEN Sep 8, 2020
5682334
add documentations to public apis
ChaoqunCHEN Sep 8, 2020
563aab7
format
ChaoqunCHEN Sep 9, 2020
60ab3ec
refine public documentations
ChaoqunCHEN Sep 10, 2020
d9beaa6
refine public documentations
ChaoqunCHEN Sep 10, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions common/api-review/installations-exp.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,22 +7,22 @@
import { FirebaseApp } from '@firebase/app-types-exp';
import { FirebaseInstallations } from '@firebase/installations-types-exp';

// @public (undocumented)
// @public
export function deleteInstallations(installations: FirebaseInstallations): Promise<void>;

// @public (undocumented)
// @public
export function getId(installations: FirebaseInstallations): Promise<string>;

// @public (undocumented)
// @public
export function getInstallations(app: FirebaseApp): FirebaseInstallations;

// @public (undocumented)
// @public
export function getToken(installations: FirebaseInstallations, forceRefresh?: boolean): Promise<string>;

// @public (undocumented)
// @public
export type IdChangeCallbackFn = (installationId: string) => void;

// @public (undocumented)
// @public
export type IdChangeUnsubscribeFn = () => void;

// @public
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ import { FirebaseInstallationsImpl } from '../interfaces/installation-impl';
import { FirebaseInstallations } from '@firebase/installations-types-exp';

/**
* Deletes the Firebase Installation and all associated data.
*
* @public
ChaoqunCHEN marked this conversation as resolved.
Show resolved Hide resolved
*/
export async function deleteInstallations(
Expand Down
3 changes: 3 additions & 0 deletions packages-exp/installations-exp/src/api/get-id.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ import { FirebaseInstallationsImpl } from '../interfaces/installation-impl';
import { FirebaseInstallations } from '@firebase/installations-types-exp';

/**
* Creates a Firebase Installation if there isn't one for the app and
* returns the Installation ID.
*
* @public
*/
export async function getId(
Expand Down
2 changes: 2 additions & 0 deletions packages-exp/installations-exp/src/api/get-installations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import { FirebaseInstallations } from '@firebase/installations-types-exp';
import { _getProvider } from '@firebase/app-exp';

/**
* Returns a Firebase Installation instance for the given app.
ChaoqunCHEN marked this conversation as resolved.
Show resolved Hide resolved
*
* @public
*/
export function getInstallations(app: FirebaseApp): FirebaseInstallations {
Expand Down
2 changes: 2 additions & 0 deletions packages-exp/installations-exp/src/api/get-token.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import {
import { FirebaseInstallations } from '@firebase/installations-types-exp';

/**
* Returns an authentication token for the current Firebase Installation.
ChaoqunCHEN marked this conversation as resolved.
Show resolved Hide resolved
*
* @public
*/
export async function getToken(
Expand Down
6 changes: 5 additions & 1 deletion packages-exp/installations-exp/src/api/on-id-change.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,22 @@ import { FirebaseInstallationsImpl } from '../interfaces/installation-impl';
import { FirebaseInstallations } from '@firebase/installations-types-exp';

/**
* An user defined callback function that takes action when Installations ID changes.
ChaoqunCHEN marked this conversation as resolved.
Show resolved Hide resolved
*
* @public
*/
export type IdChangeCallbackFn = (installationId: string) => void;
/**
* An unsubscribe function that will remove the onIdChange callback when called.
ChaoqunCHEN marked this conversation as resolved.
Show resolved Hide resolved
*
* @public
*/
export type IdChangeUnsubscribeFn = () => void;

/**
* Sets a new callback that will get called when Installation ID changes.
* Returns an unsubscribe function that will remove the callback when called.
*
*
* @public
*/
export function onIdChange(
Expand Down
4 changes: 3 additions & 1 deletion packages-exp/installations-types-exp/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@
*/

/**
* A Firebase Installation instance which is a required argument for all Firebase Installations operations.
ChaoqunCHEN marked this conversation as resolved.
Show resolved Hide resolved
*
* @public
*/
export interface FirebaseInstallations {}

/**
* An interface for Firebase internal SDKs use only.
*
*
* @internal
*/
export interface _FirebaseInstallationsInternal {
Expand Down
2 changes: 1 addition & 1 deletion packages-exp/installations-types-exp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@
"devDependencies": {
"typescript": "4.0.2"
}
}
}