Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fis modularization #3751

Merged
merged 28 commits into from
Sep 17, 2020
Merged

Fis modularization #3751

merged 28 commits into from
Sep 17, 2020

Conversation

ChaoqunCHEN
Copy link
Contributor

@ChaoqunCHEN ChaoqunCHEN commented Sep 9, 2020 •
edited
Loading

Add documentation to public APIs.

ChaoqunCHEN and others added 26 commits August 13, 2020 11:40
@ChaoqunCHEN
copied orginal FIS sdk into packages-expp and made unit tests passed
8b42af1
@ChaoqunCHEN
migrated test app and fixed a test app bug to make it worked
41cd275
@ChaoqunCHEN
made installations-exp depend on app-exp
4947925
@ChaoqunCHEN
Relocated public methods files into folder
a67daa4
@ChaoqunCHEN
Making installations mudularization step1, build success
5d5001a
@ChaoqunCHEN
Making installations mudularization step2, unit tests pass
3aa24dd
@ChaoqunCHEN
update dependency version, merge master
39c39eb
@ChaoqunCHEN
Merge branch 'master' into fis-modularization
0af33d4
@ChaoqunCHEN @Feiyang1
Apply suggestions from code review
bbc121c 
Co-authored-by: Feiyang <[email protected]>
@ChaoqunCHEN
update dependencies' version
93e1215
@ChaoqunCHEN
Merge branch 'master' into fis-modularization
9570f71
@ChaoqunCHEN
add getInstallation(app)
aa2c9a0
@ChaoqunCHEN
correct deleteInstallations funciton name
e2a1930
@ChaoqunCHEN
Place the call to registerVerion and registerInstallations at the sam…
9b46a8f 
…e place
@ChaoqunCHEN
remove dead code
36e93da
@ChaoqunCHEN
add api extractor config
3d3d36c
@ChaoqunCHEN
rewrite the internal interface
8e36c93
@ChaoqunCHEN
Merge branch 'master' into fis-modularization
be162a3
@ChaoqunCHEN
fix build error
4aa04bc
@ChaoqunCHEN
Seperate internal interface from public interface.
ce48439
@ChaoqunCHEN
Change public methods to accept public interface
1df33cc
@ChaoqunCHEN
Merge branch 'master' into fis-modularization
19bab1c
@Feiyang1
Fixes and api extractor integration for @firebase/installations-exp (#…
5876ea8 
…3733)

* integrate api-extractor into installations-exp

* add release tag to APIs

* add _ prefix to the internal interface

* update api report
@ChaoqunCHEN
merge master
2b554a2
@ChaoqunCHEN
add documentations to public apis
5682334
@ChaoqunCHEN
format
563aab7
@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2020 •
edited
Loading

💥 No Changeset

Latest commit: d9beaa6

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (a8ff3db) Head (7c20550) Diff
    browser 248 kB 249 kB +389 B (+0.2%)
    esm2017 196 kB 196 kB +41 B (+0.0%)
    main 482 kB 483 kB +1.01 kB (+0.2%)
    module 246 kB 246 kB +389 B (+0.2%)
    react-native 196 kB 196 kB +41 B (+0.0%)

  • @firebase/firestore/exp

    Type Base (a8ff3db) Head (7c20550) Diff
    browser 189 kB 190 kB +395 B (+0.2%)
    main 474 kB 478 kB +4.38 kB (+0.9%)
    module 189 kB 190 kB +395 B (+0.2%)
    react-native 189 kB 190 kB +395 B (+0.2%)

  • @firebase/firestore/lite

    Type Base (a8ff3db) Head (7c20550) Diff
    browser 64.3 kB 64.3 kB -42 B (-0.1%)
    main 142 kB 141 kB -71 B (-0.1%)
    module 64.3 kB 64.3 kB -42 B (-0.1%)
    react-native 64.6 kB 64.5 kB -42 B (-0.1%)

  • @firebase/firestore/memory

    Type Base (a8ff3db) Head (7c20550) Diff
    browser 186 kB 187 kB +252 B (+0.1%)
    esm2017 147 kB 147 kB -48 B (-0.0%)
    main 356 kB 357 kB +890 B (+0.3%)
    module 184 kB 185 kB +252 B (+0.1%)
    react-native 147 kB 147 kB -48 B (-0.0%)

  • firebase

    Type Base (a8ff3db) Head (7c20550) Diff
    firebase-firestore.js 286 kB 287 kB +392 B (+0.1%)
    firebase-firestore.memory.js 226 kB 226 kB +254 B (+0.1%)
    firebase.js 830 kB 830 kB +392 B (+0.0%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 9, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (a8ff3db) and head commit (7c20550).

Test Logs

@hsubox76 hsubox76 requested a review from egilmorez September 14, 2020 22:16
hsubox76
hsubox76 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending @egilmorez review of doc comment text.

@ChaoqunCHEN ChaoqunCHEN merged commit 7086f4a into master Sep 17, 2020
@firebase firebase locked and limited conversation to collaborators Oct 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@andirayo andirayo andirayo approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChaoqunCHEN @google-oss-bot @andirayo @hsubox76 @Feiyang1