Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Firestore Integration tests against mangled sources #2533

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Run Firestore Integration tests against mangled sources #2533

merged 5 commits into from
Jan 23, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jan 13, 2020 •
edited
Loading

This changes the Firestore integration test to use the .min.js files that we now create (#2495).

On top of that, there are two changes:

  • We can't minify RPC error codes as they are used in string comparisons. To make that work, I added the RPC error code file to our externs.
  • I moved an integration tests that used the Private API to the internal folder. This means that the test gets run as part of packages/firestore but not integration/firestore

hsubox76
hsubox76 approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@schmidt-sebastian schmidt-sebastian merged commit d9bf41c into master Jan 23, 2020
@firebase firebase locked and limited conversation to collaborators Feb 23, 2020
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-1 branch February 28, 2020 23:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@hsubox76 hsubox76

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmidt-sebastian @hsubox76