Add minified ("mangled") Firestore build #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
schmidt-sebastian
force-pushed
the
mrschmidt/sdkminifier
branch
from
7a176ff to
8037b6b
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/sdkminifier
branch
from
ecf9dd0 to
090eb7f
Compare
schmidt-sebastian
changed the title
hsubox76
reviewed
Jan 8, 2020
|
Sorry - most of our design docs (including this one) are internal only for now. I can promise that it is not all that interesting :) |
schmidt-sebastian
force-pushed
the
mrschmidt/sdkminifier
branch
from
19bba3b to
7e7a174
Compare
hsubox76
approved these changes
Jan 13, 2020
packages/firestore/package.json
Outdated
| "rollup-plugin-node-resolve": "5.2.0", | ||
| "rollup-plugin-replace": "2.2.0", | ||
| "rollup-plugin-terser": "5.1.2", |
There was a problem hiding this comment.
Unless this version is important you could probably move up to terser 5.1.3 and not have 2 separate versions in yarn.lock
There was a problem hiding this comment.
Updated to 5.1.3. Thanks!
|
Will this also be part of the Firebase package? Did not see a version bump yet 😄 |
|
This hasn't been released yet. We are working on it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sending this one out for early review. Doc for more context: go/minification
This PR adds a new Firestore where most identifiers a mangled (a size saving of 9% gzipped). I don't know too much about the Rollup pipeline, so any suggestions there are more than appreciated.
The basic steps involved in this minification/mangling are:
The output of this process are a couple of new files:
We discussed internally to only have a single build and make our default build use the new mangled property names. That might be coming before we release this, but we need to figure out how to run our integration test against the mangled build first.