Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to enable pod tests in post submit tests. #7451

Merged
merged 5 commits into from
Feb 4, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/test_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ on:
# open will be triggered when a pull request is created.
# synchronize will be triggered when a pull request has new commits.
# closed will be triggered when a pull request is closed.
types: [open, synchronize, closed]
types: [opened, synchronize, closed]

jobs:
check:
if: github.repository == 'Firebase/firebase-ios-sdk' && github.event.action == 'synchronize'
if: github.repository == 'Firebase/firebase-ios-sdk' && (github.event.action == 'opened' || github.event.action == 'synchronize')
name: Check changed files
outputs:
database_run_job: ${{ steps.check_files.outputs.database_run_job }}
Expand All @@ -28,9 +28,10 @@ jobs:
run: ./scripts/code_coverage_report/get_updated_files.sh

pod-lib-lint-database:
# Don't run on private repo unless it is a PR.
if: github.repository == 'Firebase/firebase-ios-sdk' && (needs.check.outputs.database_run_job == 'true' || github.event.pull_request.merged == true)
needs: check
# Don't run on private repo unless it is a PR.
# always() will trigger this job when `needs` are skipped in a `merge` pull_request event.
if: always() && github.repository == 'Firebase/firebase-ios-sdk' && (needs.check.outputs.database_run_job == 'true' || github.event.pull_request.merged)
runs-on: macOS-latest
strategy:
matrix:
Expand All @@ -47,9 +48,9 @@ jobs:
path: /Users/runner/*.xcresult

pod-lib-lint-functions:
# Don't run on private repo unless it is a PR.
if: github.repository == 'Firebase/firebase-ios-sdk' && (needs.check.outputs.functions_run_job == 'true' || github.event.pull_request.merged == true)
needs: check
# Don't run on private repo unless it is a PR.
if: always() && github.repository == 'Firebase/firebase-ios-sdk' && (needs.check.outputs.functions_run_job == 'true'|| github.event.pull_request.merged)
runs-on: macOS-latest
strategy:
matrix:
Expand Down