Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to enable pod tests in post submit tests. #7451

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Conversation

granluo
Copy link
Contributor

@granluo granluo commented Feb 4, 2021

Previously in post submit, pod test jobs will not run since their dependency job, check, does not run and their if conditions are overridden by needs. This was discussed here. To make if with a higher priority than needs, Job status check functions are added here. always() here will omit the result of needs jobs but will wait until dependency jobs finish.

@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@google-oss-bot
Copy link

google-oss-bot commented Feb 4, 2021

Coverage Report

Affected SDKs

  • FirebaseDatabase-ios-FirebaseDatabase-Unit-unit.xctest

    SDK overall coverage changed from ? (156f7f3) to 82.01% (f45262f) by ?.

    Click to show coverage changes in 37 files.
    Filename Base (156f7f3) Head (f45262f) Diff
    Base64.m ? 0.00% ?
    FArraySortedDictionaryTest.m ? 97.66% ?
    FCompoundHashTest.m ? 100.00% ?
    FCompoundWriteTest.m ? 100.00% ?
    FDevice.m ? 0.00% ?
    FEventTester.m ? 0.00% ?
    FIRAuthInteropFake.m ? 80.00% ?
    FIRDataSnapshotTests.m ? 98.21% ?
    FIRFakeApp.m ? 0.00% ?
    FIRMutableDataTests.m ? 100.00% ?
    FIROptionsMock.m ? 100.00% ?
    FIRTestAuthTokenProvider.m ? 0.00% ?
    FLevelDBStorageEngineTests.m ? 96.26% ?
    FMockStorageEngine.m ? 63.13% ?
    FNextPushIdTest.m ? 100.00% ?
    FNodeTests.m ? 100.00% ?
    FPathTests.m ? 100.00% ?
    FPersistenceManagerTest.m ? 100.00% ?
    FPruneForestTest.m ? 100.00% ?
    FPruningTest.m ? 100.00% ?
    FQueryParamsTest.m ? 100.00% ?
    FRangeMergeTest.m ? 95.07% ?
    FRepoInfoTest.m ? 100.00% ?
    FSparseSnapshotTests.m ? 96.70% ?
    FSyncPointTests.m ? 95.01% ?
    FTestAuthTokenGenerator.m ? 0.00% ?
    FTestBase.m ? 10.66% ?
    FTestCachePolicy.m ? 51.72% ?
    FTestClock.m ? 100.00% ?
    FTestExpectations.m ? 0.00% ?
    FTestHelpers.h ? 0.00% ?
    FTestHelpers.m ? 19.55% ?
    FTrackedQueryManagerTest.m ? 100.00% ?
    FTreeSortedDictionaryTests.m ? 97.47% ?
    FTupleEventTypeString.m ? 0.00% ?
    FUtilitiesTest.m ? 100.00% ?
    SenTest+FWaiter.m ? 0.00% ?
  • FirebaseDatabase-ios-FirebaseDatabase.framework

    SDK overall coverage changed from ? (156f7f3) to 57.22% (f45262f) by ?.

    Click to show coverage changes in 103 files.
    Filename Base (156f7f3) Head (f45262f) Diff
    APLevelDB.mm ? 61.56% ?
    FAckUserWrite.m ? 83.78% ?
    FArraySortedDictionary.m ? 97.60% ?
    FAtomicNumber.m ? 100.00% ?
    FAuthTokenProvider.m ? 73.53% ?
    FCacheNode.m ? 100.00% ?
    FCachePolicy.m ? 17.14% ?
    FCancelEvent.m ? 0.00% ?
    FChange.m ? 88.24% ?
    FChildChangeAccumulator.m ? 65.22% ?
    FChildEventRegistration.m ? 0.00% ?
    FChildrenNode.m ? 90.93% ?
    FClock.m ? 100.00% ?
    FCompoundHash.m ? 97.92% ?
    FCompoundWrite.m ? 91.45% ?
    FConnection.m ? 27.56% ?
    FDataEvent.m ? 28.57% ?
    FEmptyNode.m ? 100.00% ?
    FEventEmitter.m ? 0.00% ?
    FEventGenerator.m ? 95.69% ?
    FEventRaiser.m ? 33.33% ?
    FIRDataSnapshot.m ? 89.86% ?
    FIRDatabase.m ? 14.98% ?
    FIRDatabaseComponent.m ? 17.39% ?
    FIRDatabaseConfig.m ? 60.38% ?
    FIRDatabaseQuery.m ? 4.22% ?
    FIRDatabaseReference.m ? 6.47% ?
    FIRMutableData.m ? 75.51% ?
    FIRNoopAuthTokenProvider.m ? 0.00% ?
    FIRRetryHelper.m ? 88.37% ?
    FIRServerValue.m ? 0.00% ?
    FIRTransactionResult.m ? 0.00% ?
    FImmutableSortedDictionary.m ? 31.03% ?
    FImmutableSortedSet.m ? 54.22% ?
    FImmutableTree.m ? 85.54% ?
    FIndex.m ? 91.67% ?
    FIndexedFilter.m ? 96.60% ?
    FIndexedNode.m ? 97.14% ?
    FKeepSyncedEventRegistration.m ? 0.00% ?
    FKeyIndex.m ? 62.16% ?
    FLLRBEmptyNode.m ? 75.00% ?
    FLLRBValueNode.m ? 86.01% ?
    FLeafNode.m ? 85.00% ?
    FLevelDBStorageEngine.m ? 73.55% ?
    FLimitedFilter.m ? 95.63% ?
    FListenComplete.m ? 0.00% ?
    FMaxNode.m ? 60.61% ?
    FMerge.m ? 88.10% ?
    FNamedNode.m ? 63.38% ?
    FNextPushId.m ? 63.30% ?
    FOperationSource.m ? 89.29% ?
    FOverwrite.m ? 81.48% ?
    FPath.m ? 94.04% ?
    FPathIndex.m ? 87.80% ?
    FPendingPut.m ? 0.00% ?
    FPersistenceManager.m ? 58.93% ?
    FPersistentConnection.m ? 22.30% ?
    FPriorityIndex.m ? 87.01% ?
    FPruneForest.m ? 90.80% ?
    FQueryParams.m ? 96.59% ?
    FQuerySpec.m ? 87.76% ?
    FRangeMerge.m ? 94.69% ?
    FRangedFilter.m ? 90.36% ?
    FRepo.m ? 13.71% ?
    FRepoInfo.m ? 73.15% ?
    FRepoManager.m ? 30.20% ?
    FSRWebSocket.m ? 41.60% ?
    FServerValues.m ? 49.21% ?
    FSnapshotHolder.m ? 100.00% ?
    FSnapshotUtilities.m ? 62.14% ?
    FSparseSnapshotTree.m ? 97.41% ?
    FStringUtilities.m ? 74.42% ?
    FSyncPoint.m ? 92.24% ?
    FSyncTree.m ? 76.11% ?
    FTrackedQuery.m ? 75.76% ?
    FTrackedQueryManager.m ? 90.40% ?
    FTransformedEnumerator.m ? 100.00% ?
    FTree.m ? 5.92% ?
    FTreeNode.m ? 100.00% ?
    FTreeSortedDictionary.m ? 96.42% ?
    FTreeSortedDictionaryEnumerator.m ? 100.00% ?
    FTupleNodePath.m ? 0.00% ?
    FTupleObjectNode.m ? 0.00% ?
    FTuplePathValue.m ? 100.00% ?
    FTupleRemovedQueriesEvents.m ? 100.00% ?
    FTupleSetIdPath.m ? 0.00% ?
    FTupleStringNode.m ? 0.00% ?
    FTupleTransaction.m ? 0.00% ?
    FTupleUserCallback.m ? 0.00% ?
    FUtilities.m ? 74.61% ?
    FValidation.m ? 26.42% ?
    FValueEventRegistration.m ? 0.00% ?
    FValueIndex.m ? 49.28% ?
    FView.m ? 88.07% ?
    FViewCache.m ? 100.00% ?
    FViewProcessor.m ? 91.66% ?
    FViewProcessorResult.m ? 100.00% ?
    FWebSocketConnection.m ? 40.16% ?
    FWriteRecord.m ? 46.24% ?
    FWriteTree.m ? 75.63% ?
    FWriteTreeRef.m ? 100.00% ?
    NSData+SRB64Additions.m ? 85.71% ?
    fbase64.c ? 28.92% ?
  • FirebaseFunctions-ios-FirebaseFunctions-Unit-unit.xctest

    SDK overall coverage changed from ? (156f7f3) to 99.05% (f45262f) by ?.

    Filename Base (156f7f3) Head (f45262f) Diff
    FIRAuthInteropFake.m ? 80.00% ?
    FIRFunctionsTests.m ? 100.00% ?
    FIRMessagingInteropFake.m ? 100.00% ?
    FUNContextProviderTests.m ? 100.00% ?
    FUNSerializerTests.m ? 100.00% ?
  • FirebaseFunctions-ios-FirebaseFunctions.framework

    SDK overall coverage changed from ? (156f7f3) to 33.55% (f45262f) by ?.

    Filename Base (156f7f3) Head (f45262f) Diff
    FIRFunctions.m ? 11.82% ?
    FIRHTTPSCallable.m ? 0.00% ?
    FUNContext.m ? 100.00% ?
    FUNError.m ? 0.00% ?
    FUNSerializer.m ? 80.38% ?
    FUNUsageValidation.m ? 0.00% ?

Test Logs

@granluo granluo requested a review from paulb777 February 4, 2021 02:16
@granluo granluo merged commit 8197ddb into master Feb 4, 2021
@granluo granluo deleted the update_push branch February 4, 2021 17:08
@firebase firebase locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants