Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Export Filter type from Firestore #2192

Merged
merged 9 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions etc/firebase-admin.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ export namespace firestore {
import DocumentSnapshot = _firestore.DocumentSnapshot;
import FieldPath = _firestore.FieldPath;
import FieldValue = _firestore.FieldValue;
import Filter = _firestore.Filter;
import Firestore = _firestore.Firestore;
import FirestoreDataConverter = _firestore.FirestoreDataConverter;
import GeoPoint = _firestore.GeoPoint;
Expand Down
3 changes: 3 additions & 0 deletions etc/firebase-admin.firestore.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { DocumentReference } from '@google-cloud/firestore';
import { DocumentSnapshot } from '@google-cloud/firestore';
import { FieldPath } from '@google-cloud/firestore';
import { FieldValue } from '@google-cloud/firestore';
import { Filter } from '@google-cloud/firestore';
import { Firestore } from '@google-cloud/firestore';
import { FirestoreDataConverter } from '@google-cloud/firestore';
import { GeoPoint } from '@google-cloud/firestore';
Expand Down Expand Up @@ -78,6 +79,8 @@ export { FieldPath }

export { FieldValue }

export { Filter }

export { Firestore }

export { FirestoreDataConverter }
Expand Down
1 change: 1 addition & 0 deletions src/firestore/firestore-namespace.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export namespace firestore {
export import DocumentSnapshot = _firestore.DocumentSnapshot;
export import FieldPath = _firestore.FieldPath;
export import FieldValue = _firestore.FieldValue;
export import Filter = _firestore.Filter;
export import Firestore = _firestore.Firestore;
export import FirestoreDataConverter = _firestore.FirestoreDataConverter;
export import GeoPoint = _firestore.GeoPoint;
Expand Down
1 change: 1 addition & 0 deletions src/firestore/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export {
DocumentSnapshot,
FieldPath,
FieldValue,
Filter,
Firestore,
FirestoreDataConverter,
GeoPoint,
Expand Down
4 changes: 4 additions & 0 deletions test/integration/firestore.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ describe('admin.firestore', () => {
expect(typeof admin.firestore.FieldValue).to.be.not.undefined;
});

it('admin.firestore.Filter type is defined', () => {
expect(typeof admin.firestore.Filter).to.be.not.undefined;
});

it('admin.firestore.GeoPoint type is defined', () => {
expect(typeof admin.firestore.GeoPoint).to.be.not.undefined;
});
Expand Down