-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(firestore): Export Filter
type from Firestore
#2192
Conversation
Co-authored-by: Dan Reynolds <[email protected]>
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jhuleatt and @danReynolds!
LGTM!
Discussion
Fixes #2191, missing export for
Filter
from Firestore. This builds off of #2167 (and includes @danReynolds as commit co-author) by addressing #2167 (comment).Testing
Added a test to ensure
Filter
is exported