Schemaization of the data #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomanuel
reviewed
Jan 4, 2020
diegomanuel
changed the title
… parsed) into a given struct module. Using it from Coophub.Repos.Warmer and CoophubWeb.Fixtures.
diegomanuel
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step before adding new data sources (like gitlab, see #4).
The idea is to use
OrganizationandRepositoryschemas with their own structs.The cache will be pushed with those structs.
The
cache_warmershould be refactored into a generic builder and each client data source (github/gitlab) having its own way of getting data but always mapping into our schemas.