Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract github API into its own module and refactor cache warmer to use it #48

Closed
diegomanuel opened this issue Feb 17, 2020 · 1 comment
Closed

Extract github API into its own module and refactor cache warmer to use it #48

diegomanuel opened this issue Feb 17, 2020 · 1 comment
Assignees
@diegomanuel

Comments

@diegomanuel
Copy link
Member

Related to #4, as second step to archieve gitlab support (the first one was the PR #47).

The repos_warmer should be refactored to call behaviourized functions to fetch data from external sources. The first source will be github (and after this, in another issue, the gitlab one).

Each external source module should implement the required functions to fetch the remote data and return structs defined at #47 (Organization and Repository).
@diegomanuel diegomanuel self-assigned this Feb 17, 2020
diegomanuel added a commit that referenced this issue Feb 22, 2020
@diegomanuel
[#48] Renaming Repos.Warmer to CacheWarmer and adding basic Backends.…
d59ab8a 
…Behaviour implemented at Backends.Github for get_org/2, get_members/1, get_repos/1, get_topics/2 and headers/0 (WIP).
@diegomanuel diegomanuel mentioned this issue Feb 22, 2020
Merged
diegomanuel added a commit that referenced this issue Feb 23, 2020
@diegomanuel
[#48] Cleaning Backends.Behaviour, adjusting Backends.Github and crea…
a470dd2 
…ted Coophub.Backends.call_api_get/2.
diegomanuel added a commit that referenced this issue Feb 23, 2020
@diegomanuel
[#48] Fixing dialyzer warnings and getting to work "make test" target…
2df61aa 
… that runs "mix dialyzer --check=false" + "mix test".
diegomanuel added a commit that referenced this issue Feb 24, 2020
@diegomanuel
[#48] Some refactor at CacheWarmer, Backends and Behaviour.
b94508e
diegomanuel added a commit that referenced this issue Feb 26, 2020
@diegomanuel
[#48] Moving all the backend calls to Coophub.Backends and changing t…
f463721 
…he behaviour to just have the minimal needed specific implementation.
diegomanuel added a commit that referenced this issue Feb 26, 2020
@diegomanuel
[#48] Little refactor for Backends.Github.
8d7f6e6
diegomanuel added a commit that referenced this issue Feb 26, 2020
@diegomanuel
[#48] Moving the key and yml_data attributes setting from CacheWarmer…
40941f7 
… to Backends.
diegomanuel added a commit that referenced this issue Mar 15, 2020
@diegomanuel
[#48] Renaming type 'data_for_request' to 'request_data'.
cd737d9
diegomanuel added a commit that referenced this issue Mar 15, 2020
@diegomanuel
[#48] Extract github API into its own module and refactor cache warme…
bf53ceb 
…r to use it (#50)

* Created 3 modules: Coophub.Backends, Coophub.Backends.Behaviour and Coophub.Backends.Github.
* Renaming Repos.Warmer to CacheWarmer.
* Created Makefile with some useful targets.
* Adding dep "dialyzex" to have "mix dialyzer".
@diegomanuel
Copy link
Member Author

Done at PR #50! Will be deployed at release v0.1.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegomanuel diegomanuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diegomanuel