Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPM package is 1.42 Mb! #82

Closed
Vadorequest opened this issue Mar 16, 2020 · 1 comment · Fixed by #104
Closed

NPM package is 1.42 Mb! #82

Vadorequest opened this issue Mar 16, 2020 · 1 comment · Fixed by #104
Labels
enhancement

Comments

@Vadorequest
Copy link

https://www.npmjs.com/package/filestack-react

image

Here is what contains the package:
image

The demo folder should NOT be part of the npm package. Also, the tests aren't useful either.
Removing those 2 will decrease the package's size by around 95%.
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
refactor(whole project): - Remove webpack, reduce bundle size, bump v…
185b308 
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
@jakubpeksa jakubpeksa mentioned this issue Nov 26, 2020
Merged
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
refactor(whole project): - Remove webpack, reduce bundle size, bump v…
bd9fe0c 
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
refactor(whole project): - Remove webpack, reduce bundle size, bump v…
1a5378d 
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
refactor(whole project): - Remove webpack, reduce bundle size, bump v…
9ed6284 
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
@Vadorequest
Copy link
Author

@pcholuj Saw this on bundlephobia. (tree shacking)
Don't know if it's an issue.

https://bundlephobia.com/[email protected]

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@Vadorequest @MowiliMi