Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everytime you open the modal, another set of source options are appended #103

Closed
sgtpenguin opened this issue Nov 12, 2020 · 6 comments · Fixed by #104
Closed

Everytime you open the modal, another set of source options are appended #103

sgtpenguin opened this issue Nov 12, 2020 · 6 comments · Fixed by #104

Comments

@sgtpenguin
Copy link

To reproduce: Open the file picker, close it, then open it again. You can see every time a new set of source options (local,link,facebook,etc.) are appended to the bar on the left
Screen Shot 2020-11-12 at 10 29 48 AM

@brunopopf
Copy link

Same problem...

jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
jakubpeksa pushed a commit that referenced this issue Nov 26, 2020
…ersion, rewrite all

Completely rewrite project which implies

BREAKING CHANGE: We've removed source, file, action props, actionOptions is now called
pickerOptions, we've splitted picker component into 3 different one

fix #103, fix #82, fix #77, fix #74
@anixonCatalyst
Copy link

I am running into the same issue, is there a workaround for this?

@jakubpeksa
Copy link

Can you provide codepen? I cannot reproduce that on demo

@sgtpenguin
Copy link
Author

sgtpenguin commented Dec 8, 2020

I can't reproduce it on the demo you provided either, but it's hard to play with it because it's minified and uses compiled code. When I try to make my own codepen I cannot successfully import the library. I get an error:

Uncaught Error: [Package Error] "punycode" does not exist. (Imported by "node:punycode").

@jakubpeksa Can you please provide a working codepen demo that imports the package from NPM and uses jsx syntax and I will try to reproduce the issue?

@anixonCatalyst
Copy link

@jakubpeksa
I had the same issue when trying to get this working with react, but I can duplicate the issue using plain JS. The problem seems to be limited to calling open on the same instance of the picker multiple times.

example here

@jakubpeksa
Copy link

Regarding punycode error - I'll check it out tomorrow but I can't run it now also - that should be fixed with the newest 4.0.0 filestack-react version which will use the newest react, it'll be deployed within a month and I'll keep you updated about that.
@anixonCatalyst Thanks for example! That looks like filestack-js core library problem which you can report here https://github.com/filestack/filestack-js/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants