Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed an issue with admin operations not working #13545

Merged
merged 17 commits into from
Oct 22, 2023

Conversation

gave92
Copy link
Member

@gave92 gave92 commented Oct 19, 2023

Resolved / Related Issues

ShellFileOperations2.cs is the same file added for #13359 with a small change.

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    1. Copy, delete, rename, etc files from a protected folder

@gave92 gave92 changed the title Admin proc Fix: Fixed admin operations not working Oct 19, 2023
@hishitetsu
Copy link
Member

It doesn't show progress, but I still think it is very nice!
Here are a few things I noticed.

  • It would be better to show progress as indeterminate.
  • Occasionally the following exception occurs:
2023-10-20 08:56:19.6985|Error|System.ArgumentException: Source object type is not a projected type and does not inherit from a projected type. (Parameter 'value')
   at WinRT.CastExtensions.GetRefForObject(Object value)
   at WinRT.CastExtensions.As[TInterface](Object value)
   at Files.App.Dialogs.ElevateConfirmDialog.ElevateConfirmDialog_obj3_Bindings.SetDataRoot(Object newDataRoot)
   at Files.App.Dialogs.ElevateConfirmDialog.ElevateConfirmDialog_obj3_Bindings.DataContextChangedHandler(FrameworkElement sender, DataContextChangedEventArgs args)
   at ABI.Windows.Foundation.TypedEventHandler`2.Do_Abi_Invoke[TSenderAbi,TResultAbi](Void* thisPtr, TSenderAbi sender, TResultAbi args)

@gave92 gave92 closed this Oct 21, 2023
@gave92 gave92 reopened this Oct 22, 2023
@gave92 gave92 marked this pull request as ready for review October 22, 2023 10:39
@yaira2 yaira2 changed the title Fix: Fixed admin operations not working Fix: Fixed an issue with admin operations not working Oct 22, 2023
yaira2
yaira2 previously approved these changes Oct 22, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 22, 2023
@gave92
Copy link
Member Author

gave92 commented Oct 22, 2023

One sec "Yes" it's not showing

@gave92
Copy link
Member Author

gave92 commented Oct 22, 2023

Done! :)

@yaira2 yaira2 merged commit 34dc389 into files-community:main Oct 22, 2023
2 checks passed
@gave92 gave92 deleted the admin_proc branch October 22, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Files fails all admin oprations
3 participants