Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added speed graph to the status center #13359

Merged
merged 128 commits into from
Oct 22, 2023

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Sep 12, 2023

Summary

we're happy that we are going to introduce the sofisticated filesystem operation speed graph. Although this feature has been eagerly requested, there's been some techinical limitations. However, now the app uses WinAppSdk, there's nothing that stops us from improving this area. In addition to the graph, we've also improved UI and UX by using new our own icons and new string resources.

Task Checklist

  • Get toal size of processing items
  • Get total size parallelly even if some source items are directories
  • Calculate operation speed every time the progress increased by 1%
  • Add the speed graph
  • Add the operation speed text
  • Add current processing file name on the footer for each
  • Add canceled state card color brush
  • Improve string resources
  • Fixed an issue where extracting shows more that 100% progress
  • Fixed an issue where compression and extraction does not stop when cancelled
  • Improved extraction speed performance
  • Brush up
  • Apply requested changes

Known issues

Following issues would be fixed in the upcoming PR.

  • The shell API of deletion returns pretty wrong item count
  • The shell API of recycling doesn't return any information including progress and speed
  • If the path is over MAX_PATH (256), the operation will fallback to the Win32API instead of the Win32 Shell API and it doesn't support progress report.

PR Checklist

Steps To Validate Changes

The things reviewers should look at

  • Calculated total item count and size correctly
  • Displayed current processing item name correctly
  • The progress is shown correctly
  • The graph point moves smoothly and correctly
  • The operation is cancelable if applicable
  • The tooltip, which includes source and destination paths, will be shown on hovering header and subheader.

Operation Kinds

  • Copying
  • Moving
  • Recyling
  • Deleting
  • Decompressing
  • Compressing
  • Emptying the Bin

Item Type Kinds

  • Multiple items
  • Single item
  • Including folders

Screenshots

image

@yaira2 yaira2 changed the title Feature: Add filesystem operation progress graph Feature: Added speed graph to status center Sep 12, 2023
@0x5bfa 0x5bfa marked this pull request as draft September 15, 2023 11:24
src/Files.App/App.xaml Outdated Show resolved Hide resolved
yaira2
yaira2 previously approved these changes Oct 20, 2023
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x5bfa 0x5bfa requested review from yaira2 and hez2010 October 22, 2023 00:42
yaira2
yaira2 previously approved these changes Oct 22, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Oct 22, 2023
@yaira2 yaira2 merged commit b112b02 into files-community:main Oct 22, 2023
2 checks passed
@yaira2 yaira2 changed the title Feature: Added speed graph to status center Feature: Added speed graph to the status center Oct 22, 2023
@gave92 gave92 deleted the 5bfa/Add-TransferGraph branch October 22, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Display transfer speed in status center
7 participants