-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Fixed an issue where it wasn't possible to edit some file permissions #12142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 5bfa/fix-security
…nto 5bfa/fix-security
…nto 5bfa/fix-security
…nto 5bfa/fix-security
@0x5bfa can you link the issue for these changes? |
Done. |
@QuaintMako Could you review? |
I should be able in the upcoming days, probably around Sunday at worst. |
QuaintMako
reviewed
May 5, 2023
src/Files.App/ViewModels/Properties/SecurityAdvancedViewModel.cs
Outdated
Show resolved
Hide resolved
Also, I did not test any fonctionnality, I'm not versed at all in the security processes. |
QuaintMako
previously approved these changes
May 5, 2023
yaira2
reviewed
May 5, 2023
yaira2
reviewed
May 5, 2023
yaira2
reviewed
May 5, 2023
yaira2
reviewed
May 5, 2023
Co-authored-by: Yair <[email protected]>
Co-authored-by: Yair <[email protected]>
…nto 5bfa/fix-security
yaira2
previously approved these changes
May 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yaira2
added
ready to merge
Pull requests that are approved and ready to merge
and removed
needs - code review
labels
May 7, 2023
yaira2
changed the title
Fix: Fix an issue where some security functionalities are missing
Fix: Fixed an issue where some it wasn't possible to edit some file permissions
May 8, 2023
yaira2
changed the title
Fix: Fixed an issue where some it wasn't possible to edit some file permissions
Fix: Fixed an issue where it wasn't possible to edit some file permissions
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an issue which has been reported.
Motivation and Context
I've been aware of that there're a lot of lack of function. As a part of improving, I fix an issue where some security functionalities are missing.
Validation
Removal & Its Rationale
PR Checklist
Screenshots