Feature: Integrate Advanced Security page into properties window

[0x5bfa]

Feature: Integrate Advanced Security page into properties window

Motivation and Context

Planned by Files team

Details of changes

• Integrate Advanced Security page into properties window
• Update titlebar text styling
• Update the height of each NavigationViewItem from 40px to 36px (32px is default)
• Tweaked UI in all properties pages
• Add backward navigation functionality in properties window
• Use generalized Parameter class for every class in Properties

PR Checklist

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?
  1. Go to properties window
  2. Navigate to Security tab
  3. Click 'Advanced permissions' button

Screenshots

Backward navigation button & new titlebar looks & Integrated SecurityAdvancedPage

[yaira2]

Is this ready for review?

[0x5bfa]

@yaira2 Yes done.

[yaira2]

The UI changes look good to me.

[ferrariofilippo]

I think we should add the item name to the window name. If a user has multiple properties opened (not on the general page) it might be hard to tell which one belongs to which item

[ferrariofilippo]

There are a couple things that might be changed. Apart from them, LGTM

[ferrariofilippo]

LGTM

[yaira2]

@0x5bfa thank you for all your hard work on this PR. This has been on the todo list for almost 2 years but it kept getting put off due to the size and other priorities so I'm happy it's finally taken care of.

[yaira2]

@0x5bfa was this removed on purpose?