Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Storage Client Deal List Pagination #5880

Closed
wants to merge 70 commits into from

Conversation

aarshkshah1992
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 commented Mar 25, 2021

For #4185.

Depends on #5853

TODO

Stebalien and others added 30 commits March 11, 2021 20:10
Otherwise, this won't work on 32bit ARM.
Can specify miner actor address when terminate sectors,
so that you can terminate sectors without miner api.
…eset_to_1_5_3

Chore/backport nerpa reset to 1 5 3
better logging when unsealing fails
api: Document StateReplay replaced message behavior
perf: add cache for gas permium estimation
- allows tipset apply and revert to be observed
- motivating use case running a lotus-sentinel node
Implement Event observer and Settings for 3rd party dep injection
* mostly working api proxy gen

* api: Consistent api names

* fix docsgen

* regenerate api struct

* api: expand external interfaces

* Add missing gen files

* apigen: fix perm detection

* api: Move perm tags to the interface

* gofmt

* worker perms

* docsgen

* docsgen: ignore tag comments

* apigen: add codegen warning

* gofmt

* missing actor type

* docsgen

* make linter happy

* fix lint

* apigen: use directives for tags

* docsgen

* regen openrpc docs
raulk and others added 3 commits March 25, 2021 13:02
* force packer build

* disable ami temporarially

* apt and ufw

* initial lotus config

* rename correctly

* apt-get instead of apt

* undo temporary edits

* install before upgrade

* tmp - force digitalocean

* reenable filters

* uncomment ebs

* tmp, remove filter for digitalocean build

* doc

* install ufw (for iams where it isn't installed)

* more amazon regions

* missing comma

* missing comma

* remove unavailable regions

* switch to ubuntu, not minimal

* pro server

* change owner

* change image

* uncomment circleci filters

* remove api from firewall

* tmp: remove circleci filter

* dpkg options

* confold

* try export

* re-add filter
@dirkmc dirkmc mentioned this pull request Mar 25, 2021
4 tasks
expose NextID from nice market actor interface
fix: make sure atomic 64bit fields are 64bit aligned
cli/client.go Outdated
DefaultText: "no-op",
},
&cli.IntFlag{
Name: "deals-per-page",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's have a default for deals-per-page. 50 seems like a reasonable default.

…s-for-perm-on-error

chore: add available options for perm on error
Add --actor flag in lotus-shed sectors terminate
@aarshkshah1992 aarshkshah1992 changed the base branch from master to feat/markets-v1.2.0 March 26, 2021 09:28
@aarshkshah1992
Copy link
Contributor Author

aarshkshah1992 commented Mar 26, 2021

@dirkmc @jennijuju

All possible options with which we can filter

arshshah@Aarshs-MacBook-Pro lotus % lotus client list-deals --help                                                      
NAME:
   lotus client list-deals - List storage market deals

USAGE:
   also supports pagination, please see supported options for more details

CATEGORY:
   STORAGE

OPTIONS:
   --verbose, -v                 print verbose deal details (default: false)
   --color                       use color in display output (default: true)
   --watch                       watch deal updates in real-time, rather than a one time list (default: false)
   --hide-failed                 hide failed/failing deals (default: false)
   --creation-time-offset value  minimum creation time offset of the deals to include in the deal list page (default: no-op)
   --limit value                 number of deals to show in the deal list page (default: 50)
   --min-start-epoch value       minimum start epoch of the deals to include in the deal list page (default: no-op)
   --max-end-epoch value         maximum end epoch of the deals to include in the deal list page (default: no-op)
   --help, -h                    show help (default: false)

All Deals

aarshshah@Aarshs-MacBook-Pro lotus % lotus client list-deals -v

Created                    DealCid                                                      DealId  Provider  State                         On Chain?       Slashed?  PieceCID                                                          Size       Price                     Duration  TransferChannelID                                                                                                              TransferStatus  Verified  Message
2021-03-26T13:24:26+05:30  bafyreibcacybtma7rdfycjkognrl6wdty3lkmrdvys4jtoqbiwi2uziuaa  10      f01000    StorageDealAwaitingPreCommit  Y (epoch 1629)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.000402281072888688 FIL  1300994   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884001  Completed       false     
2021-03-26T13:26:21+05:30  bafyreic33ishws3swia2j4wwajlavv7ullpii237pqygtm4o4fwttsdayu  11      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.00040227210578268 FIL   1300965   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884002  Completed       false     
2021-03-26T13:26:26+05:30  bafyreib4yuxx6jmtjonlfdvpi3wk7vmvtvhi6d6teo2qhqscpkznt7gvbq  13      f01000    StorageDealActive    Y (epoch 1628)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.000402271796572128 FIL  1300964   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884004  Completed       false     
2021-03-26T13:26:31+05:30  bafyreibj47awsvzkblc4r6xln7elgh5r6gr4ftbvqo67i3sbjyfhk75mr4  14      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.000402271487361576 FIL  1300963   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884005  Completed       false     
2021-03-26T13:26:34+05:30  bafyreignj7x7smarnhd7ndbgrsi6xtwwnanxndhtww7fsc2tadnnrwnhru  12      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.000402271178151024 FIL  1300962   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884003  Completed       false 

Just show the first two deals

aarshshah@Aarshs-MacBook-Pro lotus % lotus client list-deals -v --limit=2

Created                    DealCid                                                      DealId  Provider  State                         On Chain?       Slashed?  PieceCID                                                          Size       Price                     Duration  TransferChannelID                                                                                                              TransferStatus  Verified  Message
2021-03-26T13:24:26+05:30  bafyreibcacybtma7rdfycjkognrl6wdty3lkmrdvys4jtoqbiwi2uziuaa  10      f01000    StorageDealAwaitingPreCommit  Y (epoch 1629)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.000402281072888688 FIL  1300994   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884001  Completed       false     
2021-03-26T13:26:21+05:30  bafyreic33ishws3swia2j4wwajlavv7ullpii237pqygtm4o4fwttsdayu  11      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         baga6ea4seaqkmjd7eh6ypntkvtnfp65fjgqhhta44vik7ths7hkrrp32scruujy  1.984 KiB  0.00040227210578268 FIL   1300965   12D3KooWHxkZnb2UHS23QAE6Hs2GptYQpziQXaHwpHjnZGHdXtkf-12D3KooWGBzFUDEw14UtJg1MeYrN5b8UNnyNBgqjumrB9p3wfqQ7-1616743172515884002  Completed       false     

Show deals after a certain time offset

aarshshah@Aarshs-MacBook-Pro lotus % lotus client list-deals --creation-time-offset="2021-03-26T13:26:21+05:30"
DealCid      DealId  Provider  State                         On Chain?       Slashed?  PieceCID     Size       Price                     Duration  Verified  
...wttsdayu  11      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         ...2scruujy  1.984 KiB  0.00040227210578268 FIL   1300965   false     
...znt7gvbq  13      f01000    StorageDealActive             Y (epoch 1628)  N         ...2scruujy  1.984 KiB  0.000402271796572128 FIL  1300964   false     
...fhk75mr4  14      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         ...2scruujy  1.984 KiB  0.000402271487361576 FIL  1300963   false     
...nnrwnhru  12      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         ...2scruujy  1.984 KiB  0.000402271178151024 FIL  1300962   false

Show the first two deals after a certain time offset

aarshshah@Aarshs-MacBook-Pro lotus % lotus client list-deals --creation-time-offset="2021-03-26T13:26:21+05:30" --limit=2
DealCid      DealId  Provider  State                         On Chain?       Slashed?  PieceCID     Size       Price                     Duration  Verified  
...wttsdayu  11      f01000    StorageDealAwaitingPreCommit  Y (epoch 1630)  N         ...2scruujy  1.984 KiB  0.00040227210578268 FIL   1300965   false     
...znt7gvbq  13      f01000    StorageDealActive             Y (epoch 1628)  N         ...2scruujy  1.984 KiB  0.000402271796572128 FIL  1300964   false   

@aarshkshah1992
Copy link
Contributor Author

Closed in favour of #5886.

@Kubuxu Kubuxu deleted the feat/integrate-pagination branch November 25, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.