Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paging to deal list #4185

Closed
4 tasks
jennijuju opened this issue Oct 6, 2020 · 6 comments
Closed
4 tasks

Add paging to deal list #4185

jennijuju opened this issue Oct 6, 2020 · 6 comments

Comments

@jennijuju
Copy link
Member

jennijuju commented Oct 6, 2020

For clients have huge amount of deals, list-deals takes a long time to load(related #4131), also is hard to read when the list is too long. Adding paging when querying may help.

Idea:

lotus client list-deal --startEpoch=<> --endEpoch=<>
lotus client list-deal --afterCreationTime=<>

Required steps:

@jennijuju jennijuju added area/ux Area: UX area/markets Area: Markets labels Oct 6, 2020
@dineshshenoy
Copy link

This probably needs to be changed in the API to add paging? Should we expand the scope to add paging for all "list" API calls?

https://github.com/filecoin-project/lotus/blob/master/documentation/en/api-methods.md#clientlistdeals

@vyzo
Copy link
Contributor

vyzo commented Mar 22, 2021

We should do this after the v1 api is a thing, so it is blocked.

@aarshkshah1992
Copy link
Contributor

aarshkshah1992 commented Mar 24, 2021

@dirkmc

Do we need this ONLY for storage clients or retreival clients as well ?

@Fatman13
Copy link
Contributor

Fatman13 commented Mar 25, 2021

Would be nice to alias the start and end epoch too if that make any sense. Say, list-deal --slingshot2.2.

@vyzo vyzo removed their assignment Mar 26, 2021
@dkkapur dkkapur added this to the 🤝 Deal Success milestone May 19, 2021
@dkkapur dkkapur added the P2 P2: Should be resolved label May 19, 2021
@s0nik42
Copy link

s0nik42 commented Jun 29, 2021

and by status and from

--status StorageDealActive,StorageDealWaitingForData
--from f3rmy6c7zoefq3bb4thhvmv35ihe4t35hyaivoxdrzzmtt5zx6hrdp4ltgzccndggynjkc3joxxok3quv5mg2a,f144zep4gitj73rrujd3jw6iprljicx6vl4wbeavi

@jennijuju jennijuju removed this from the 🤝 Deal Success milestone Mar 3, 2022
@TippyFlitsUK
Copy link
Contributor

Hi 👋

The Legacy Lotus Markets sub-system reached EOL at the end of the 31st January 2023.

This ticket is being marked as won't fix and closed as the Lotus Team will no longer be making any further fixes or enhancements to the legacy markets subsystem.

Please feel free to re-open this ticket in the new Boost markets sub-system repository at https://github.com/filecoin-project/boost if you feel that it is still relevant.

Many thanks 🙏

@TippyFlitsUK TippyFlitsUK added status/won't fix and removed P2 P2: Should be resolved labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants